From: Mark Brown <broonie@kernel.org>
To: Kalesh Singh <kaleshsingh@google.com>
Cc: mark.rutland@arm.com, will@kernel.org, maz@kernel.org,
qperret@google.com, tabba@google.com, surenb@google.com,
kernel-team@android.com, James Morse <james.morse@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Peter Collingbourne <pcc@google.com>,
Alexei Starovoitov <ast@kernel.org>,
"Madhavan T. Venkataraman" <madvenka@linux.microsoft.com>,
Andrew Jones <drjones@redhat.com>,
Zenghui Yu <yuzenghui@huawei.com>, Keir Fraser <keirf@google.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] KVM: arm64: Compile stacktrace.nvhe.o
Date: Fri, 29 Apr 2022 13:47:26 +0100 [thread overview]
Message-ID: <YmveXly9117jbWKr@sirena.org.uk> (raw)
In-Reply-To: <20220427184716.1949239-2-kaleshsingh@google.com>
[-- Attachment #1: Type: text/plain, Size: 890 bytes --]
On Wed, Apr 27, 2022 at 11:46:56AM -0700, Kalesh Singh wrote:
> Recompile stack unwinding code for use with the nVHE hypervisor. This is
> a preparatory patch that will allow reusing most of the kernel unwinding
> logic in the nVHE hypervisor.
This is substantially more than just the build change that the changelog
would seem to indicate... it would I think be clearer to split this up
further with the code changes separated out and explained a bit more.
It's not just recompling the code for nVHE, there's also refactoring to
split out changes that don't apply in nVHE hypervisor like all the task
related code which is needed but not mentioned in the changlog at all.
Possibly a patch or two for the code motion then a separate patch for
the ifdefs and build changes?
I *think* the code is all fine but I'd need to go through it a few more
times to be sure I didn't miss anything.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-04-29 12:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 18:46 [PATCH 0/4] KVM nVHE Hypervisor stack unwinder Kalesh Singh
2022-04-27 18:46 ` [PATCH 1/4] KVM: arm64: Compile stacktrace.nvhe.o Kalesh Singh
2022-04-29 12:47 ` Mark Brown [this message]
2022-04-29 16:25 ` Kalesh Singh
2022-04-27 18:46 ` [PATCH 2/4] KVM: arm64: Add hypervisor overflow stack Kalesh Singh
2022-04-27 18:46 ` [PATCH 3/4] KVM: arm64: Allocate shared stacktrace pages Kalesh Singh
2022-04-27 18:46 ` [PATCH 4/4] KVM: arm64: Unwind and dump nVHE hypervisor stacktrace Kalesh Singh
2022-04-29 13:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmveXly9117jbWKr@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alexandru.elisei@arm.com \
--cc=ast@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=drjones@redhat.com \
--cc=james.morse@arm.com \
--cc=kaleshsingh@google.com \
--cc=keirf@google.com \
--cc=kernel-team@android.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=madvenka@linux.microsoft.com \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=mhiramat@kernel.org \
--cc=pcc@google.com \
--cc=qperret@google.com \
--cc=surenb@google.com \
--cc=suzuki.poulose@arm.com \
--cc=tabba@google.com \
--cc=wangkefeng.wang@huawei.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox