From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19C99C433F5 for ; Thu, 12 May 2022 21:58:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359015AbiELV5w (ORCPT ); Thu, 12 May 2022 17:57:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358985AbiELV5i (ORCPT ); Thu, 12 May 2022 17:57:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A3865DBF0 for ; Thu, 12 May 2022 14:57:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7850F61FB4 for ; Thu, 12 May 2022 21:57:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A80BCC385B8; Thu, 12 May 2022 21:57:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652392655; bh=yU6s+/+h1gRHCRJ83nqrVGKUBm1fWFm2gD7n/no4qEw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OfRePn8vFReViGnjqaf4Nuft1lzf0vc4DKD3h+LbhvH6CM39JZSzNUPEntffy6ttr g6X8q5mMz1ISEEbjxJXT15mcjtbt8vm3zdrFTOfzVIH7h1o0o96np1souzIUJxNWw/ kNjIwLU3cSe2ruxp8kQ6d6QSw9xQtjGToehOCDS8BNr0KKPRYXRiqpMx9INN3e3kkL R3HqBa/hYDEFwM/o38E8P8x7PVA7GTA/vifavMuEVY9nBZohrRq9dfrgkzVYf7aOw7 U3DFUr3W2eifkwpn4rMCjzomDJEf0vqkRmwGhxxWt+DZlX5OL0Yx0hx7063xnULI4i TkghMnuhvOn7A== Date: Thu, 12 May 2022 14:57:34 -0700 From: Jaegeuk Kim To: Chao Yu Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chao Yu Subject: Re: [PATCH] f2fs: separate NOCoW and pinfile semantics Message-ID: References: <20220512082116.2991611-1-chao@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220512082116.2991611-1-chao@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/12, Chao Yu wrote: > Pinning a file is heavy, because skipping pinned files make GC > running with heavy load or no effect. > > So that this patch proposes to separate nocow and pinfile semantics: > - NOCoW flag can only be set on regular file. > - NOCoW file will only trigger IPU at common writeback/flush. > - NOCow file will do OPU during GC. > > This flag can satisfying the demand of: > 1) avoiding fragment of file's physical block > 2) userspace doesn't want to pin file's physical address > > Signed-off-by: Chao Yu > --- > fs/f2fs/data.c | 3 ++- > fs/f2fs/f2fs.h | 1 + > fs/f2fs/file.c | 25 ++++++++++++++++++++++++- > 3 files changed, 27 insertions(+), 2 deletions(-) > > diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c > index 54a7a8ad994d..c8eab78f7d89 100644 > --- a/fs/f2fs/data.c > +++ b/fs/f2fs/data.c > @@ -2495,7 +2495,8 @@ bool f2fs_should_update_inplace(struct inode *inode, struct f2fs_io_info *fio) > if (is_inode_flag_set(inode, FI_ALIGNED_WRITE)) > return false; > > - if (f2fs_is_pinned_file(inode)) > + if (f2fs_is_pinned_file(inode) || > + F2FS_I(inode)->i_flags & F2FS_NOCOW_FL) > return true; > > /* if this is cold file, we should overwrite to avoid fragmentation */ > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h > index 492af5b96de1..e91ece55f5e8 100644 > --- a/fs/f2fs/f2fs.h > +++ b/fs/f2fs/f2fs.h > @@ -2916,6 +2916,7 @@ static inline void f2fs_change_bit(unsigned int nr, char *addr) > #define F2FS_NOCOMP_FL 0x00000400 /* Don't compress */ > #define F2FS_INDEX_FL 0x00001000 /* hash-indexed directory */ > #define F2FS_DIRSYNC_FL 0x00010000 /* dirsync behaviour (directories only) */ > +#define F2FS_NOCOW_FL 0x00800000 /* Do not cow file */ > #define F2FS_PROJINHERIT_FL 0x20000000 /* Create with parents projid */ > #define F2FS_CASEFOLD_FL 0x40000000 /* Casefolded file */ > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > index 09287876dbb7..7f92a3a157f7 100644 > --- a/fs/f2fs/file.c > +++ b/fs/f2fs/file.c > @@ -1851,6 +1851,20 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask) > if (IS_NOQUOTA(inode)) > return -EPERM; > > + if ((iflags ^ masked_flags) & F2FS_NOCOW_FL) { > + int ret; > + > + if (!S_ISREG(inode->i_mode)) > + return -EINVAL; > + if (f2fs_should_update_outplace(inode, NULL)) > + return -EINVAL; > + if (f2fs_is_pinned_file(inode)) > + return -EINVAL; > + ret = f2fs_convert_inline_inode(inode); > + if (ret) > + return ret; > + } > + > if ((iflags ^ masked_flags) & F2FS_CASEFOLD_FL) { > if (!f2fs_sb_has_casefold(F2FS_I_SB(inode))) > return -EOPNOTSUPP; > @@ -1926,6 +1940,7 @@ static const struct { > { F2FS_NOCOMP_FL, FS_NOCOMP_FL }, > { F2FS_INDEX_FL, FS_INDEX_FL }, > { F2FS_DIRSYNC_FL, FS_DIRSYNC_FL }, > + { F2FS_NOCOW_FL, FS_NOCOW_FL }, > { F2FS_PROJINHERIT_FL, FS_PROJINHERIT_FL }, > { F2FS_CASEFOLD_FL, FS_CASEFOLD_FL }, > }; > @@ -1957,7 +1972,8 @@ static const struct { > FS_NOCOMP_FL | \ > FS_DIRSYNC_FL | \ > FS_PROJINHERIT_FL | \ > - FS_CASEFOLD_FL) > + FS_CASEFOLD_FL | \ > + FS_NOCOW_FL) > > /* Convert f2fs on-disk i_flags to FS_IOC_{GET,SET}FLAGS flags */ > static inline u32 f2fs_iflags_to_fsflags(u32 iflags) > @@ -3081,6 +3097,13 @@ static int f2fs_ioc_set_pin_file(struct file *filp, unsigned long arg) > > inode_lock(inode); > > + if (F2FS_I(inode)->i_flags & F2FS_NOCOW_FL) { > + f2fs_info(F2FS_I_SB(inode), "inode (%lu) is already NOCOW one", > + inode->i_ino); > + ret = -EINVAL; Why rejecting this? We can pin the file to get 2MB-aligned allocation on the NOCOW file. > + goto out; > + } > + > if (!pin) { > clear_inode_flag(inode, FI_PIN_FILE); > f2fs_i_gc_failures_write(inode, 0); > -- > 2.25.1