From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAB0CC433FE for ; Sat, 14 May 2022 05:09:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231734AbiENFJn (ORCPT ); Sat, 14 May 2022 01:09:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231766AbiENFJi (ORCPT ); Sat, 14 May 2022 01:09:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57950DEBA; Fri, 13 May 2022 22:09:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B6BF360A24; Sat, 14 May 2022 05:09:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89F3CC34116; Sat, 14 May 2022 05:09:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652504975; bh=RvNHeiqwtSeyUphn9A3Kul7Zvpq+Ly64hYUFjpyel4Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HS1QigauKuCUtyWE3I05D8MCfWOQrc410MVvZV7gwHB9p/Wq+uahZoS1e/R9sRJeK 8+FthfMCtuU7cO5N3w2R2rtRdAvLvqvXl2Hvm0PW3DwEe5ovirXi/GyBQLitEJ7tir Yxsdtej3q2c7N16OM35xqnd5UsQR/70wMUUJnrXOHAKbfCoyhLclYj1RGvcX2IEyRV r8mWqVDPLd7JZycoAZlQ/z7D3h44D12sFitZoKKbmgzJCNQk1N4WFV1pTiQkwInL8T yhsd4CZHD8HNdHLsX5GumVi+BxouxTUNrYB2JK4Qfv6clBEekFxqiMdtY7VLSYTQ7q hMrdTeVXBcbMQ== Date: Sat, 14 May 2022 08:09:28 +0300 From: Leon Romanovsky To: Rohit Sajan Kumar Cc: "matanb@mellanox.com" , "dledford@redhat.com" , "sean.hefty@intel.com" , "hal.rosenstock@gmail.com" , Manjunath Patil , Rama Nichanamatlu , "linux-rdma@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] net/mlx5: Add sysfs entry for vhca to /sys/class/infiniband/mlx5 Message-ID: References: <1652137257-5614-1-git-send-email-rohit.sajan.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 13, 2022 at 05:46:16PM +0000, Rohit Sajan Kumar wrote: > Hey, > > Sending this as a gentle reminder to review the patch sent earlier this week which can be found in this email chain. Patches that sent in HTML format, to wrong addresses and not visible in patchworks/ML, without target net-next/rdma-next/e.t.c., with wrong title are generally ignored. Why vhca_id that returned from MLX5_IB_METHOD_QUERY_PORT is not enough? Anyway, sysfs file in IB driver for the property of mlx5_core is no-go. Thanks > > Thank you. > > Best, > Rohit. > ________________________________ > From: Rohit Nair > Sent: Monday, May 9, 2022 4:00 PM > To: matanb@mellanox.com ; leonro@mellanox.com ; dledford@redhat.com ; sean.hefty@intel.com ; hal.rosenstock@gmail.com ; Rohit Sajan Kumar ; Manjunath Patil ; Rama Nichanamatlu > Cc: linux-rdma@vger.kernel.org ; linux-kernel@vger.kernel.org > Subject: [PATCH] net/mlx5: Add sysfs entry for vhca to /sys/class/infiniband/mlx5 > > While collecting diagnostic information (Ex:wqdump) in virtual > environment, we need vhca id to collect data belonging a particular VF. > This patch adds a sysfs entry to show the vhca id inside guest. > > Signed-off-by: Rohit Nair > --- > drivers/infiniband/hw/mlx5/main.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c > index 32a0ea8..dd935bc 100644 > --- a/drivers/infiniband/hw/mlx5/main.c > +++ b/drivers/infiniband/hw/mlx5/main.c > @@ -2499,12 +2499,24 @@ static ssize_t board_id_show(struct device *device, > } > static DEVICE_ATTR_RO(board_id); > > +static ssize_t vhca_id_show(struct device *device, > + struct device_attribute *attr, char *buf) > +{ > + struct mlx5_ib_dev *dev = > + container_of(device, struct mlx5_ib_dev, ib_dev.dev); > + return sysfs_emit(buf, "%d [0x%x]\n", > + MLX5_CAP_GEN(dev->mdev, vhca_id), > + MLX5_CAP_GEN(dev->mdev, vhca_id)); > +} > +static DEVICE_ATTR_RO(vhca_id); > + > static struct attribute *mlx5_class_attributes[] = { > &dev_attr_hw_rev.attr, > &dev_attr_hca_type.attr, > &dev_attr_board_id.attr, > &dev_attr_fw_pages.attr, > &dev_attr_reg_pages.attr, > + &dev_attr_vhca_id.attr, > NULL, > }; > > -- > 1.8.3.1 >