From: Minchan Kim <minchan@kernel.org>
To: Alexey Romanov <avromanov@sberdevices.ru>
Cc: ngupta@vflare.org, senozhatsky@chromium.org,
linux-block@vger.kernel.org, axboe@chromium.org,
kernel@sberdevices.ru, linux-kernel@vger.kernel.org,
mnitenko@gmail.com, Dmitry Rokosov <ddrokosov@sberdevices.ru>
Subject: Re: [PATCH v4] zram: remove double compression logic
Date: Wed, 4 May 2022 16:02:48 -0700 [thread overview]
Message-ID: <YnMGGMitdYg/5e4z@google.com> (raw)
In-Reply-To: <20220504121243.63407-1-avromanov@sberdevices.ru>
On Wed, May 04, 2022 at 03:12:43PM +0300, Alexey Romanov wrote:
> The 2nd trial allocation under per-cpu presumption has been
> used to prevent regression of allocation failure. However, it
> makes trouble for maintenance without significant benefit.
> The slowpath branch is executed extremely rarely: getting
> there is problematic. Therefore, we delete this branch.
Let's add about the stable_write, too in the description.
"Since b09ab054b69b, zram has used QUEUE_FLAG_STABLE_WRITES to prevent
buffer change between 1st and 2nd memory allocations. Since we remove
second trial memory allocation logic, we could remove the STABLE_WRITES
flag because there is no change buffer to be modified under us"
>
> Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru>
> Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru>
Other than that, looks good to me.
Acked-by: Minchan Kim <minchan@kernel.org>
Please send the updated patch again with To: Andrew Morton <akpm@linux-foundation.org>
with keeping Ccing.
prev parent reply other threads:[~2022-05-04 23:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 12:12 [PATCH v4] zram: remove double compression logic Alexey Romanov
2022-05-04 23:02 ` Minchan Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnMGGMitdYg/5e4z@google.com \
--to=minchan@kernel.org \
--cc=avromanov@sberdevices.ru \
--cc=axboe@chromium.org \
--cc=ddrokosov@sberdevices.ru \
--cc=kernel@sberdevices.ru \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mnitenko@gmail.com \
--cc=ngupta@vflare.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox