Re: [patch 0/3] x86/fpu: Prevent FPU state corruption

Filipe Manana
2022-05-02T10:03:36Z

On Sun, May 01, 2022 at 09:31:42PM +0200, Thomas Gleixner wrote:
> The recent changes in the random code unearthed a long standing FPU state
> corruption due do a buggy condition for granting in-kernel FPU usage.

Thanks for fixing this. I had been reliably hitting that fpu state splat
since 5.18-rc1 with fstests, and was annoying because it made a few tests
fail (fstests reports a failure whenever there's a splat or warning in
dmesg).

I confirm that with this patchset applied the issue no longer happens and
everything seems to be working fine, so:

Tested-by: Filipe Manana <fdmanana@suse.com>

>
> The following series addresses this issue and makes the code more robust.
>
> Thanks,
>
> tglx
> ---
> arch/um/include/asm/fpu/api.h | 2
> arch/x86/include/asm/fpu/api.h | 21 +-------
> arch/x86/include/asm/simd.h | 2
> arch/x86/kernel/fpu/core.c | 92 +++++++++++++++++++-----------------
> net/netfilter/nft_set_pipapo_avx2.c | 2
> 5 files changed, 57 insertions(+), 62 deletions(-)
>
>
>