From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4ED4C433F5 for ; Thu, 5 May 2022 17:40:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1382789AbiEERnr (ORCPT ); Thu, 5 May 2022 13:43:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1382768AbiEERnl (ORCPT ); Thu, 5 May 2022 13:43:41 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 701765BE46 for ; Thu, 5 May 2022 10:40:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id CCAFCCE2ED7 for ; Thu, 5 May 2022 17:39:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0861C385A8; Thu, 5 May 2022 17:39:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651772398; bh=Fea/rsoxEnUkTCcBFJAwvQ9RkVxQQI5m8J3zJBHz8TE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MJacyXw5JQdV1zxZ6e/r0qhwiQ+k9EW9VNgnv6ulXAQEKa+weAJyctY+gywsr4JPE 9N0/t+LD3x8bdacDkRd6+rFAYvjPnHJX4mwFjH2oujFKe34RRPzFp1eDpk5f7UseK3 qEPJngQfmEl1LHxs7NInu4wJGfSJLUD4z6ajdnl0= Date: Thu, 5 May 2022 14:23:12 +0200 From: Greg KH To: "zhangjianhua (E)" Cc: jirislaby@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] vt: defkeymap.c_shipped remove unused variables Message-ID: References: <20220429014814.988829-1-chris.zjh@huawei.com> <53e36000-ad70-9de7-74ad-16bd81dae530@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <53e36000-ad70-9de7-74ad-16bd81dae530@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 05, 2022 at 11:10:55AM +0800, zhangjianhua (E) wrote: > > 在 2022/4/29 14:39, Greg KH 写道: > > On Fri, Apr 29, 2022 at 09:48:14AM +0800, Zhang Jianhua wrote: > > > The global variables 'funcbufptr' 'funcbufsize' and 'funcbufleft' have > > > been initialized but not used, they are redundant and remove them. > > > > > > -------- > > Why this extra "------" line? > > This line "------" means the end of commit message, if it is redundant, I will remove it in next version. That is not used in kernel changelogs at all, sorry. Please don't add it in future changes either. thanks, greg k-h