Re: [PATCH net-next v3 4/7] net: phy: introduce genphy_c45_pma_baset1_read_master_slave()

kernel test robot
2022-05-05T13:42:28Z

Hi Oleksij,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url: https://github.com/intel-lab-lkp/linux/commits/Oleksij-Rempel/add-ti-dp83td510-support/20220505-143922
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 4950b6990e3b1efae64a5f6fc5738d25e3b816b3
config: x86_64-randconfig-a016 (https://download.01.org/0day-ci/archive/20220505/202205052146.y8znPT8Q-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 5e004fb787698440a387750db7f8028e7cb14cfc)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/80dad43edb356876484acb116b8a906dd4bef941
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Oleksij-Rempel/add-ti-dp83td510-support/20220505-143922
git checkout 80dad43edb356876484acb116b8a906dd4bef941
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/net/phy/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/net/phy/phy-c45.c:558: warning: expecting prototype for genphy_c45_baset1_read_master_slave(). Prototype was for genphy_c45_pma_baset1_read_master_slave() instead

vim +558 drivers/net/phy/phy-c45.c

552
553 /**
554 * genphy_c45_baset1_read_master_slave - read forced master/slave configuration
555 * @phydev: target phy_device struct
556 */
557 int genphy_c45_pma_baset1_read_master_slave(struct phy_device *phydev)
> 558 {
559 int val;
560
561 phydev->master_slave_state = MASTER_SLAVE_STATE_UNKNOWN;
562
563 val = phy_read_mmd(phydev, MDIO_MMD_PMAPMD, MDIO_PMA_PMD_BT1_CTRL);
564 if (val < 0)
565 return val;
566
567 if (val & MDIO_PMA_PMD_BT1_CTRL_CFG_MST)
568 phydev->master_slave_state = MASTER_SLAVE_STATE_MASTER;
569 else
570 phydev->master_slave_state = MASTER_SLAVE_STATE_SLAVE;
571
572 return 0;
573 }
574 EXPORT_SYMBOL_GPL(genphy_c45_pma_baset1_read_master_slave);
575

--
0-DAY CI Kernel Test Service