From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id A23A8C433F5
	for <linux-kernel@archiver.kernel.org>; Thu,  5 May 2022 22:34:41 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1386406AbiEEWiS (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Thu, 5 May 2022 18:38:18 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53718 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S243371AbiEEWiK (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 5 May 2022 18:38:10 -0400
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12CDC53A47;
        Thu,  5 May 2022 15:34:30 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by ams.source.kernel.org (Postfix) with ESMTPS id B84CEB830E8;
        Thu,  5 May 2022 22:34:28 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 662E0C385AE;
        Thu,  5 May 2022 22:34:27 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
        s=korg; t=1651790067;
        bh=pRdKLJeOO/4QGSwZjRZR4WU9c4pmiE3H+nSf9u6bRa8=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=VQTrdVLN1qI1+X21HFeSDvt/B0QMqHImVVY2UZ+Zjrvasw3vg6VpKRuzFW69PFdsJ
         S4n8O8WYPLVQBIubmGisxCOb0zqECRFPjET28CbNSxd8d2uduPEmtKc/u1KzakOLWK
         sESKQx6Ww/VBMHVVpJbFbKRIj1zaFV0DoQWfB0GY=
Date:   Thu, 5 May 2022 22:50:03 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Cc:     linux-serial@vger.kernel.org, michal.simek@xilinx.com,
        jirislaby@kernel.org, git@xilinx.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] tty: xilinx_uartps: Check the clk_enable return value
Message-ID: <YnQ4e7afL/ghGnA2@kroah.com>
References: <20220429081422.3630070-1-shubhrajyoti.datta@xilinx.com>
 <20220429081422.3630070-3-shubhrajyoti.datta@xilinx.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220429081422.3630070-3-shubhrajyoti.datta@xilinx.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Apr 29, 2022 at 01:44:17PM +0530, Shubhrajyoti Datta wrote:
> Check the clk_enable return value.

That says what, but not why.

> 
> Addresses-Coverity: Event check_return.

Shouldn't this be a covertity id?

thanks,

greg k-h