From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57A8CC433F5 for ; Fri, 6 May 2022 14:03:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1441965AbiEFOHF (ORCPT ); Fri, 6 May 2022 10:07:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349347AbiEFOHA (ORCPT ); Fri, 6 May 2022 10:07:00 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1160154FA6; Fri, 6 May 2022 07:03:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C0344B835D5; Fri, 6 May 2022 14:03:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03DAAC385A8; Fri, 6 May 2022 14:03:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651845794; bh=Emk1IbJ2UesPOraVK4BnXsCwa0LZVJhuV2lPmWaVRLQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hdh/rtV4MKgB8zkWvw/OwKlwFYoiCYKaG6WsLT4UCiz1oTt+O2CSEjMjUgPP5ZMXL m2m3/hYIqEfh+vDN1jyoGhMaupgskJzP1PNv7RHmX2GuhGjXWuQweBk98X15HxfENF DkaGiDJbd8iRFp7mBilcCA2uwPLo+ayZIhvduE8M= Date: Fri, 6 May 2022 16:03:11 +0200 From: Greg Kroah-Hartman To: Muhammad Usama Anjum Cc: "Rafael J. Wysocki" , Len Brown , Hans de Goede , Mark Gross , Benson Leung , Enric Balletbo i Serra , Collabora Kernel ML , groeck@chromium.org, dtor@chromium.org, gwendal@chromium.org, vbendeb@chromium.org, andy@infradead.org, Ayman Bagabas , Benjamin Tissoires , =?utf-8?B?Qmxhxb4=?= Hrastnik , Darren Hart , Dmitry Torokhov , Jeremy Soller , Mattias Jacobsson <2pi@mok.nu>, Mauro Carvalho Chehab , Rajat Jain , Srinivas Pandruvada , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, "Rafael J . Wysocki" , chrome-platform@lists.linux.dev Subject: Re: [PATCH v9] platform/chrome: Add ChromeOS ACPI device driver Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 06, 2022 at 02:57:18PM +0500, Muhammad Usama Anjum wrote: > From: Enric Balletbo i Serra > > The x86 Chromebooks have the ChromeOS ACPI device. This driver attaches > to the ChromeOS ACPI device and exports the values reported by ACPI in a > sysfs directory. This data isn't present in ACPI tables when read > through ACPI tools, hence a driver is needed to do it. The driver gets > data from firmware using the ACPI component of the kernel. The ACPI values > are presented in string form (numbers as decimal values) or binary > blobs, and can be accessed as the contents of the appropriate read only > files in the standard ACPI device's sysfs directory tree. This data is > consumed by the ChromeOS user space. > > Cc: Rafael J. Wysocki > Cc: Dmitry Torokhov > Cc: Hans de Goede > Signed-off-by: Enric Balletbo i Serra > Co-developed-by: Muhammad Usama Anjum > Signed-off-by: Muhammad Usama Anjum > --- > The driver's implementation has been changed completely after Greg's > comment. I've updated the authorship of the module to myself. Enric, > Please let me know if yuo are comfortable with this. > > Changes in v9: > - Changed the implementation completely > - Move the driver to drivers/platform/chrome > - Remove Acked-by Rafael as driver has changed > - Corrected some typos > - Changed the author of the module Looks like you need a v10 :(