From: Jarkko Sakkinen <jarkko@kernel.org>
To: Stefan Mahnke-Hartmann <stefan.mahnke-hartmann@infineon.com>
Cc: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
Marten.Lindahl@axis.com, martenli@axis.com, jgg@ziepe.ca,
jsnitsel@redhat.com, nayna@linux.vnet.ibm.com,
johannes.holland@infineon.com, peterhuewe@gmx.de,
stable@vger.kernel.org
Subject: Re: [PATCH 1/2] tpm: Fix buffer access in tpm2_get_tpm_pt()
Date: Sat, 7 May 2022 22:43:21 +0300 [thread overview]
Message-ID: <YnbL2R/a3SwA3fMC@iki.fi> (raw)
In-Reply-To: <20220506123145.229058-1-stefan.mahnke-hartmann@infineon.com>
On Fri, May 06, 2022 at 02:31:46PM +0200, Stefan Mahnke-Hartmann wrote:
> Under certain conditions uninitialized memory will be accessed.
> As described by TCG Trusted Platform Module Library Specification,
> rev. 1.59 (Part 3: Commands), if a TPM2_GetCapability is received,
> requesting a capability, the TPM in Field Upgrade mode may return a
~~~~~~~~~~~~~~~~~~
Looks like random picks for casing: two words with upper case letter and
one with lowe case.
> zero length list.
> Check the property count in tpm2_get_tpm_pt().
>
> Fixes: 2ab3241161b3 ("tpm: migrate tpm2_get_tpm_pt() to use struct tpm_buf")
> Cc: stable@vger.kernel.org
> Signed-off-by: Stefan Mahnke-Hartmann <stefan.mahnke-hartmann@infineon.com>
Which section is this in that specification documented?
I looked into section 30.2 but could not find the part that documents this
behaviour, i.e. returning success in FW upgrade mode. Why it wouldn't just
return TPM_RC_UPGRADE?
BR, Jarkko
next prev parent reply other threads:[~2022-05-07 19:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 12:31 [PATCH 1/2] tpm: Fix buffer access in tpm2_get_tpm_pt() Stefan Mahnke-Hartmann
2022-05-06 12:31 ` [PATCH 2/2] tpm: Add Field Upgrade mode support for Infineon TPM2 modules Stefan Mahnke-Hartmann
2022-05-07 19:43 ` Jarkko Sakkinen
2022-05-09 12:50 ` Stefan Mahnke-Hartmann
2022-05-11 15:12 ` Jarkko Sakkinen
2022-05-07 19:43 ` Jarkko Sakkinen [this message]
2022-05-09 11:48 ` [PATCH 1/2] tpm: Fix buffer access in tpm2_get_tpm_pt() Stefan Mahnke-Hartmann
2022-05-11 15:11 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnbL2R/a3SwA3fMC@iki.fi \
--to=jarkko@kernel.org \
--cc=Marten.Lindahl@axis.com \
--cc=jgg@ziepe.ca \
--cc=johannes.holland@infineon.com \
--cc=jsnitsel@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martenli@axis.com \
--cc=nayna@linux.vnet.ibm.com \
--cc=peterhuewe@gmx.de \
--cc=stable@vger.kernel.org \
--cc=stefan.mahnke-hartmann@infineon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox