From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3B42C433EF for ; Mon, 9 May 2022 16:29:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239049AbiEIQdA (ORCPT ); Mon, 9 May 2022 12:33:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239029AbiEIQcw (ORCPT ); Mon, 9 May 2022 12:32:52 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8927924DC5B for ; Mon, 9 May 2022 09:28:58 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 104AC6147C for ; Mon, 9 May 2022 16:28:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2068AC385AC; Mon, 9 May 2022 16:28:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1652113737; bh=Kpy2f9+84wfDHOQehgRjqLoGX7mLUkGG/CxrJ6fKsng=; h=Date:From:To:Subject:References:In-Reply-To:From; b=Xd4kHP06aDcsQFAOx7eosfyNKwKscjUOfgLzYrVaWeFY3MnoMFZv5vOYlLfPcuhVE nAQNrfxjvQ9f5JskUgs7ugPf4r2MnlPN/V6b70579GgvEaiLp5iM3izxjsr7rCVdCG t6/OMhTpr3fpAiIYCUzoRw2Of6D2+vGW3D0lL334= Date: Mon, 9 May 2022 18:28:54 +0200 From: Greg KH To: Samuel Thibault , linux-kernel@vger.kernel.org, speakup@linux-speakup.org Subject: Re: [PATCHv2] speakup: Generate speakupmap.h automatically Message-ID: References: <20220430003934.fkua7vwoz6heigrp@begin> <20220430073321.6b4lvrrt7buzh7dp@begin> <20220509140705.n3eei4r5ko6bbex4@begin> <20220509142642.gsi5cppgadc2gojy@begin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220509142642.gsi5cppgadc2gojy@begin> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 09, 2022 at 04:26:42PM +0200, Samuel Thibault wrote: > Greg KH, le lun. 09 mai 2022 16:19:03 +0200, a ecrit: > > On Mon, May 09, 2022 at 04:07:05PM +0200, Samuel Thibault wrote: > > > Greg KH, le lun. 09 mai 2022 16:04:43 +0200, a ecrit: > > > > Any reason you can't add the code in utils.c into genmap.c and then > > > > merge into makemapdata.c to make this a single .c file that does both > > > > things? > > > > > > Yes: genmap is a tool that end-users can use without needing the Linux > > > source code, while makemapdata needs it. > > > > But who will run genmap? > > I guess you meant makemapdata? > > Long-term-wise this patchset will need a bit of work to properly install > the genmap tool so the user can call it. I'm here mostly making sure > to put into the Linux kernel how speakupmap.h is generated (rather > than the currently very magic file), while at the same time keeping > the separation between makemapdata and genmap that will make sense > longterm-wise. Ok, then it's ok to leave it as is. But the build stuff still needs to get resolved :)