From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Henning Schild <henning.schild@siemens.com>
Cc: Mark Gross <markgross@kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
linux-watchdog@vger.kernel.org, Enrico Weigelt <lkml@metux.net>,
Gerd Haeussler <gerd.haeussler.ext@siemens.com>
Subject: Re: [PATCH v2 4/4] leds: simatic-ipc-leds-gpio: add GPIO version of Siemens driver
Date: Thu, 12 May 2022 12:58:27 +0300 [thread overview]
Message-ID: <YnzaQxProKeOkR41@smile.fi.intel.com> (raw)
In-Reply-To: <20220512104424.1430c9a3@md1za8fc.ad001.siemens.net>
On Thu, May 12, 2022 at 10:44:24AM +0200, Henning Schild wrote:
> Am Wed, 11 May 2022 17:39:05 +0200
> schrieb Henning Schild <henning.schild@siemens.com>:
...
> > +config LEDS_SIEMENS_SIMATIC_IPC_GPIO
>
> I wonder if i really should introduce a new switch here or just carry
> this one under LEDS_SIEMENS_SIMATIC_IPC
>
> For a v3 i will likely put two modules under that one config switch.
For me either is okay, but I'm not a LED maintainer.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-05-12 9:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 15:39 [PATCH v2 0/4] simatic-ipc additions to p2sb apl lake gpio Henning Schild
2022-05-11 15:39 ` [PATCH v2 1/4] leds: simatic-ipc-leds: convert to use P2SB accessor Henning Schild
2022-05-11 15:39 ` [PATCH v2 2/4] watchdog: simatic-ipc-wdt: " Henning Schild
2022-05-11 18:03 ` Guenter Roeck
2022-05-12 8:58 ` Henning Schild
2022-05-12 9:57 ` Andy Shevchenko
2022-05-12 2:51 ` kernel test robot
2022-05-11 15:39 ` [PATCH v2 3/4] platform/x86: simatic-ipc: drop custom P2SB bar code Henning Schild
2022-05-11 15:39 ` [PATCH v2 4/4] leds: simatic-ipc-leds-gpio: add GPIO version of Siemens driver Henning Schild
2022-05-11 15:48 ` Henning Schild
2022-05-11 17:53 ` Andy Shevchenko
2022-05-12 8:44 ` Henning Schild
2022-05-12 9:58 ` Andy Shevchenko [this message]
2022-05-11 17:55 ` [PATCH v2 0/4] simatic-ipc additions to p2sb apl lake gpio Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnzaQxProKeOkR41@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gerd.haeussler.ext@siemens.com \
--cc=henning.schild@siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkml@metux.net \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox