From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
"Brown, Len" <len.brown@intel.com>,
Sandipan Das <sandipan.das@amd.com>,
"Pawnikar, Sumeet R" <sumeet.r.pawnikar@intel.com>,
"Hunter, Adrian" <adrian.hunter@intel.com>,
Ian Rogers <irogers@google.com>, Jiri Olsa <jolsa@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [FYI PATCH 1/1] tools arch x86: Sync the msr-index.h copy with the kernel sources
Date: Thu, 26 May 2022 15:23:51 -0300 [thread overview]
Message-ID: <Yo/Ft1msmmqb2gpX@kernel.org> (raw)
In-Reply-To: <1b985724110640719b4073e1bbec07d5@intel.com>
Em Thu, May 26, 2022 at 04:50:47PM +0000, Luck, Tony escreveu:
> Sorry for being part of the problem with this getting out of sync.
There is no problem to be sorry for :-)
> But, remind me again why tools has *copies* of this and other files.
We used not to have copies, using kernel headers directly. From time to
time tools/perf broke due to legitimate kernel hacking. At some point
Linus complained about such direct usage. Then we adopted the current
model.
The way these headers are used in perf are not restricted to just
including them to compile something. There are, as described in the log
message for this sync, scripts that convert defines into string tables,
etc, so some change may break one of these scripts, or new MSRs may use
some different #define pattern, etc.
Having the tools/perf/check-headers.sh script, part of building tools,
point out new changes in the original files lets people check what
happened and sometimes just do as I did, update.
>o Seems like pointless work to keep them in sync.
I hope to have clarified.
- Arnaldo
next prev parent reply other threads:[~2022-05-26 18:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 15:55 [FYI PATCH 1/1] tools arch x86: Sync the msr-index.h copy with the kernel sources Arnaldo Carvalho de Melo
2022-05-26 16:50 ` Luck, Tony
2022-05-26 18:23 ` Arnaldo Carvalho de Melo [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-02-22 19:21 Arnaldo Carvalho de Melo
2022-03-29 19:28 Arnaldo Carvalho de Melo
2021-11-13 14:19 [FYI][PATCH " Arnaldo Carvalho de Melo
2021-05-03 15:00 Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yo/Ft1msmmqb2gpX@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=hdegoede@redhat.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=sandipan.das@amd.com \
--cc=sumeet.r.pawnikar@intel.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox