From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8182C433F5 for ; Tue, 24 May 2022 16:59:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239774AbiEXQ7a (ORCPT ); Tue, 24 May 2022 12:59:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239789AbiEXQ7Y (ORCPT ); Tue, 24 May 2022 12:59:24 -0400 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AFA07C179 for ; Tue, 24 May 2022 09:59:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1653411560; x=1684947560; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=G8zqKzbAC43VBmVdOb+NPWZaQn7ZOrqgIiOJCocAtuM=; b=QNPOxklweYtOQRoMk/zHqQUropfckaz3MuVuWe/CH1SJqwPNOj0KfZMN hjKk1sYxO50q/RELxJ2/qEJLE9C/qHAt8N768cUHfD85hCcEGrX2sxnhL yzI2qPpC9bj5+o2Y3b1Vum8CooopOky0zqxMBODAWW7VI5wgv3sw1WWem w=; Received: from unknown (HELO ironmsg02-sd.qualcomm.com) ([10.53.140.142]) by alexa-out-sd-01.qualcomm.com with ESMTP; 24 May 2022 09:59:19 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg02-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2022 09:59:19 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 24 May 2022 09:59:19 -0700 Received: from qian (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 24 May 2022 09:59:17 -0700 Date: Tue, 24 May 2022 12:59:15 -0400 From: Qian Cai To: Zi Yan CC: David Hildenbrand , , , , Vlastimil Babka , Mel Gorman , Eric Ren , Mike Rapoport , "Oscar Salvador" , Christophe Leroy , Andrew Morton Subject: Re: [PATCH v11 0/6] Use pageblock_order for cma and alloc_contig_range alignment. Message-ID: References: <0E75B247-8150-48A3-83AE-56C586030006@nvidia.com> <48D48FDC-B8DD-41C9-B56A-EBD7314883AB@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 22, 2022 at 12:54:04PM -0400, Zi Yan wrote: > Can you try the patch below on top of linux-next to see if it fixes the infinite loop issue? > Thanks. > > 1. split_free_page() change is irrelevant but to make the code more robust. > 2. using set_migratetype_isolate() in isolate_single_pageblock() is to properly mark the pageblock > MIGRATE_ISOLATE. > 3. setting to-be-migrated page's pageblock to MIGRATE_ISOLATE is to avoid a possible race > that another thread might take the free page after migration. > 4. off-by-one fix and no retry if free page is not found after migration like I added before. Cool. I'll be running it this week and report back next week.