From: Peter Zijlstra <peterz@infradead.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
aik@ozlabs.ru, sv@linux.ibm.com, rostedt@goodmis.org,
jpoimboe@redhat.com, naveen.n.rao@linux.vnet.ibm.com,
mbenes@suse.cz, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [RFC PATCH v2 3/7] objtool: Use target file class size instead of a compiled constant
Date: Tue, 24 May 2022 19:59:57 +0200 [thread overview]
Message-ID: <Yo0dHcq7VYlt79nj@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <c4b06b5b314183d85615765a5ce421a057674bd8.1653398233.git.christophe.leroy@csgroup.eu>
On Tue, May 24, 2022 at 03:17:43PM +0200, Christophe Leroy wrote:
> - sec = elf_create_section(elf, relocname, 0, sizeof(GElf_Rela), 0);
> + if (size == sizeof(u32))
> + sec = elf_create_section(elf, relocname, 0, sizeof(Elf32_Rela), 0);
> + else
> + sec = elf_create_section(elf, relocname, 0, sizeof(GElf_Rela), 0);
Probably best to use Elf64_* here instead of GElf_*.
next prev parent reply other threads:[~2022-05-24 18:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 13:17 [RFC PATCH v2 0/7] objtool: Enable and implement --mcount option on powerpc Christophe Leroy
2022-05-24 13:17 ` [RFC PATCH v2 1/7] objtool: Fix SEGFAULT Christophe Leroy
2022-05-24 13:17 ` [RFC PATCH v2 2/7] objtool: Use target file endianness instead of a compiled constant Christophe Leroy
2022-05-24 13:17 ` [RFC PATCH v2 3/7] objtool: Use target file class size " Christophe Leroy
2022-05-24 17:59 ` Peter Zijlstra [this message]
2022-05-24 13:17 ` [RFC PATCH v2 4/7] objtool: Add --mnop as an option to --mcount Christophe Leroy
2022-05-24 13:17 ` [RFC PATCH v2 5/7] objtool: Enable objtool to run only on files with ftrace enabled Christophe Leroy
2022-05-24 18:01 ` Peter Zijlstra
2022-05-24 18:02 ` Peter Zijlstra
2022-05-24 18:59 ` Christophe Leroy
2022-05-24 19:50 ` Peter Zijlstra
2022-05-24 13:17 ` [RFC PATCH v2 6/7] objtool/powerpc: Enable objtool to be built on ppc Christophe Leroy
2022-05-24 13:17 ` [RFC PATCH v2 7/7] objtool/powerpc: Add --mcount specific implementation Christophe Leroy
2022-05-25 10:14 ` [RFC PATCH v2 0/7] objtool: Enable and implement --mcount option on powerpc Sathvika Vasireddy
2022-05-25 16:51 ` Segher Boessenkool
2022-05-25 17:39 ` Christophe Leroy
2022-05-25 18:12 ` Sathvika Vasireddy
2022-06-15 16:03 ` Christophe Leroy
2022-06-18 4:56 ` Sathvika Vasireddy
2022-06-24 7:08 ` Christophe Leroy
2022-06-24 18:44 ` Sathvika Vasireddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yo0dHcq7VYlt79nj@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=aik@ozlabs.ru \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@csgroup.eu \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mbenes@suse.cz \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
--cc=sv@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox