From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 150E1C433FE for ; Tue, 24 May 2022 22:18:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242126AbiEXWSj (ORCPT ); Tue, 24 May 2022 18:18:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238086AbiEXWSf (ORCPT ); Tue, 24 May 2022 18:18:35 -0400 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E4923AA7E for ; Tue, 24 May 2022 15:18:33 -0700 (PDT) Received: by mail-pj1-x102e.google.com with SMTP id v5-20020a17090a7c0500b001df84fa82f8so3412265pjf.5 for ; Tue, 24 May 2022 15:18:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=eupBg8LTf54BtIuUjheEXOe8DwIV/IRViMAtPJVNdh4=; b=e51izz8ZJSfSNb4qSePKnG5II1X+Htfoef3No4FJkwlRsRmSYZrrKMRWCK6Yxwznvi oyepdeE1w04FLQraw3LtniwmOWnzehmnMjgYazaSJU/DEOVqXdNas05bQi0Y/F95yIGf TRF7VT756pl7dTOV2PL6ghaSZj0ySpi+T6Dt0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eupBg8LTf54BtIuUjheEXOe8DwIV/IRViMAtPJVNdh4=; b=3AtOvz+QCICI46IOQ8GSOjNVIiG9lDwYRRXqG/9YUCpubEEKg6ADeDLA2dRIocbWbj UsOu5XeUHjPm5DEWliYhlOsaSk6mwPiwxfWEfXBw/AcCVBEpna9lhluylCHNC0ylamx7 msRCEOFQ2jWivEDoDLrbIqajMnaWUWE7l6MhC1SiwxmUopF3p9QatqDF+Hr8U+Ee7oi2 AApH411Hj5uUximc4bk2PAY+TqY4FyNShnouj9kcdIAwOgfL5MISQEoZreY7IIWEWF5H M3wfkrk6HSjJb0V4JN0H5rRIZ/HBr4vnN5yjgRAZuX4I6++KQw/EwUvlmgY+IZmQD285 W78g== X-Gm-Message-State: AOAM531sDp2Wi//RjKznJ43s/RPKcmnX4P0I+8cW4gqGWxGXQ67L9EHV 9qkbeb+XxA+5dPuPnb2Pyu1JBhFPnKXJEg== X-Google-Smtp-Source: ABdhPJztA8w5JChWAFfGwFlZBdd9gfh0N78Z0l2MRbGVMqX6joBl1WnZsEQ07XBbAeecVijtbU1nLw== X-Received: by 2002:a17:90b:4c0a:b0:1dc:e81a:f0c with SMTP id na10-20020a17090b4c0a00b001dce81a0f0cmr7018624pjb.2.1653430712974; Tue, 24 May 2022 15:18:32 -0700 (PDT) Received: from localhost ([2620:15c:11a:202:4d83:f549:9abd:427]) by smtp.gmail.com with UTF8SMTPSA id rm10-20020a17090b3eca00b001cd4989fee6sm27460pjb.50.2022.05.24.15.18.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 May 2022 15:18:32 -0700 (PDT) Date: Tue, 24 May 2022 15:18:31 -0700 From: Matthias Kaehlcke To: Douglas Anderson Cc: Bjorn Andersson , Stephen Boyd , Andy Gross , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: qcom: sc7280: Add touchscreen to villager Message-ID: References: <20220524134840.1.I80072b8815ac08c12af8f379a33cc2d83693dc51@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220524134840.1.I80072b8815ac08c12af8f379a33cc2d83693dc51@changeid> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 24, 2022 at 01:48:49PM -0700, Douglas Anderson wrote: > This adds the touchscreen to the sc7280-herobrine-villager device > tree. Note that the touchscreen on villager actually uses the reset > line and thus we use the more specific "elan,ekth6915" compatible > which allows us to specify the reset. > > The fact that villager's touchscreen uses the reset line can be > contrasted against the touchscreen for CRD/herobrine-r1. On those > boards, even though the touchscreen goes to the display, it's not > hooked up to anything there. > > In order to keep the line parked on herobrine/CRD, we'll move the > pullup from the qcard.dtsi file to the specific boards. This allows us > to disable the pullup in the villager device tree since the pin is an > output. > > Signed-off-by: Douglas Anderson Reviewed-by: Matthias Kaehlcke