From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C283C433EF for ; Wed, 25 May 2022 06:34:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244147AbiEYGeJ (ORCPT ); Wed, 25 May 2022 02:34:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244135AbiEYGeH (ORCPT ); Wed, 25 May 2022 02:34:07 -0400 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BEFD24EA13; Tue, 24 May 2022 23:34:05 -0700 (PDT) Received: from localhost ([31.220.118.249]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1N0FE1-1nfX7s1UE3-00xNHI; Wed, 25 May 2022 08:33:39 +0200 Date: Wed, 25 May 2022 08:33:38 +0200 From: Andreas Klinger To: Li Zhengyu Cc: jic23@kernel.org, lars@metafoo.de, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio: srf08: Remove redundant if statement Message-ID: References: <20220523122755.90638-1-lizhengyu3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220523122755.90638-1-lizhengyu3@huawei.com> X-Provags-ID: V03:K1:WuCXsISV+LcR2fiPYceeJ/1veCe1id+9u8nVSBSHAaEPTL1EMfD /HdLCkq1VkRj6PAc3I7PdNOlqhg8av/+vc4icCrIsjRb2rzcgEDOah1UHgl5APpDftlU849 e7vK+JdOK4qAj7pWFYxqvaxAcnm9h5X8lIClQD9ImeC2GSbdJqsbXKduJigPMTIQcTC5Hpg sQfwvUPOcKJXzMMPUCQyw== X-UI-Out-Filterresults: notjunk:1;V03:K0:/5SOd4ZNpR4=:bpPXgQM6zMLYq/zKz9NmA/ VkabMv9XhdOQslnElnrZn8GJ/1q4+84tbGPumWSEj7Ql806RI7InR4MWQrd/ZA8FsACXFyw+9 /tKNscZCOD87R3KE/TwY41PpZFC3yhEVEH6a5PNDsD0z/Qg7/o656TsT03e8c4CIT3h9qDip7 V//B9wWAGilx3UzmyjwvMJ5qek0Q6UXfS+dEoGlSRW/tln3Sny4RcFhddAXKnLnNg8BeHHtDJ wn4D2HxHHDL7llBlXkBynl3EX5jECMJgbR7fk3iUVaUnlePUvknG9QQCG+9n396PM/Zrp7JUH hL/nEK34IkQe1yb562X5pebpUUy7NjuR6GQZcOcHoVm36VHDjTIQzNOSNmv9ObEcO1jqBkhDK Pf0i40mctf4SKfQJfQqdY7NJo6h0SGe5SveOM91/yLPaRX9+YpQpp1JzXUfx/gJJokDvS24Pb e4TSY8u/s6MsLJESIXacg6I2wD4pDjLwgxV0cP3DVNhfIVtTgpVvqXr72wO+9N/0Mr8eLHBUG GsNUynfggNp0Jwx9VfoQODPPrqom4UifpJ+2KEGBUcb8gCQy8oQQwz0fysBopEe2UtP8Sx2rR yotz7TtX4uvx1RCHOJZD5nx6LpHnBODNCWNdm27NmaCH1B01r3mQGwEaVv48VnJ3mQv51ozbT MtUBoqB8EMV2pCg0noTeUH3wwPiJKYoPAEPKMKCqtMqYdyP2KR+sX0ZNlX8AcqWDNUi0Mq/QD 8gDvdMpAHmfzbbBX+zKVm3Lp+ELVtMKvAa+unQ== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Acked-by: Andreas Klinger Li Zhengyu schrieb am Mo, 23. Mai 20:27: > (!val) has been checked outside the loop, remove redundant (val &&) > from loop. > > Signed-off-by: Li Zhengyu > --- > drivers/iio/proximity/srf08.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/proximity/srf08.c b/drivers/iio/proximity/srf08.c > index ac1ab7e89d4e..7ed11339c31e 100644 > --- a/drivers/iio/proximity/srf08.c > +++ b/drivers/iio/proximity/srf08.c > @@ -354,7 +354,7 @@ static ssize_t srf08_write_sensitivity(struct srf08_data *data, > return -EINVAL; > > for (i = 0; i < data->chip_info->num_sensitivity_avail; i++) > - if (val && (val == data->chip_info->sensitivity_avail[i])) { > + if (val == data->chip_info->sensitivity_avail[i]) { > regval = i; > break; > } > -- > 2.17.1 > -- Andreas Klinger Grabenreith 27 84508 Burgkirchen +49 8623 919966 ak@it-klinger.de www.it-klinger.de www.grabenreith.de