From: Christoph Hellwig <hch@infradead.org>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: Damien Le Moal <damien.lemoal@opensource.wdc.com>,
"open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)"
<linux-ide@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
hdegoede@redhat.com
Subject: Re: [PATCH 2/3] ata: ahci: Rename module parameter for lpm policy
Date: Wed, 25 May 2022 02:03:57 -0700 [thread overview]
Message-ID: <Yo3w/dsaly+gcQNR@infradead.org> (raw)
In-Reply-To: <20220524170508.563-3-mario.limonciello@amd.com>
On Tue, May 24, 2022 at 12:05:07PM -0500, Mario Limonciello wrote:
> The LPM policy is applied to more chipsets than just mobile designs.
> Update the module parameter to drop the word "mobile" to make this
> clearer to users.
>
> Also, document this renamed parameter in the admin-guide for users
> as it was missing previously.
Even if the name is confusing I don't think we should rename it as
that breaks existing setups. I think just updating the documentation
is good enough, but if you feel strongly we can just add the new name
while keeping the old one as an alias.
next prev parent reply other threads:[~2022-05-25 9:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 17:05 [PATCH v3 0/3] Drop mobile board support Mario Limonciello
2022-05-24 17:05 ` [PATCH 1/3] ata: ahci: Drop low power policy board type Mario Limonciello
2022-05-24 17:05 ` [PATCH 2/3] ata: ahci: Rename module parameter for lpm policy Mario Limonciello
2022-05-25 9:03 ` Christoph Hellwig [this message]
2022-05-25 11:11 ` Damien Le Moal
2022-05-24 17:05 ` [PATCH 3/3] ahci: Document the loss of hotplug by new LPM policy Mario Limonciello
2022-05-25 9:04 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yo3w/dsaly+gcQNR@infradead.org \
--to=hch@infradead.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=hdegoede@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox