From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: Marvin Lin <milkfafa@gmail.com>
Cc: mchehab@kernel.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org, kwliu@nuvoton.com,
tmaimon77@gmail.com, avifishman70@gmail.com,
openbmc@lists.ozlabs.org, tali.perry1@gmail.com,
kflin@nuvoton.com
Subject: Re: [PATCH v2 5/5] drivers: media: platform: Add NPCM Video Capture/Encode Engine driver
Date: Tue, 17 May 2022 15:30:35 +0200 [thread overview]
Message-ID: <YoOje2L13q7d7KeI@latitude> (raw)
In-Reply-To: <20220513033450.7038-6-kflin@nuvoton.com>
[-- Attachment #1: Type: text/plain, Size: 863 bytes --]
Hello,
first of all, thank you for bringing this driver upstream.
On Fri, May 13, 2022 at 11:34:50AM +0800, Marvin Lin wrote:
> Add driver for Video Capture/Differentiation Engine (VCD) and Encoding
> Compression Engine (ECE) present on Nuvoton NPCM SoCs.
>
> Signed-off-by: Marvin Lin <kflin@nuvoton.com>
> ---
> drivers/media/platform/Kconfig | 1 +
> drivers/media/platform/Makefile | 1 +
> drivers/media/platform/nuvoton/Kconfig | 12 +
> drivers/media/platform/nuvoton/Makefile | 2 +
> drivers/media/platform/nuvoton/npcm-video.c | 2074 +++++++++++++++++++
Similar to what I said in reply to the bindings patch, I would prefer to
have the VCD code and the ECE code in two separate files, if possible,
to make reuse of the VCD code alone (on WPCM450) easier.
Best regards,
Jonathan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-05-17 13:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 3:34 [PATCH v2 0/5] Support Nuvoton NPCM Video Capture/Encode Engine Marvin Lin
2022-05-13 3:34 ` [PATCH v2 1/5] arm: dts: Add node for " Marvin Lin
2022-05-13 5:22 ` Paul Menzel
2022-05-17 1:55 ` Kun-Fa Lin
2022-05-13 3:34 ` [PATCH v2 2/5] dt-bindings: media: Add dt-bindings " Marvin Lin
2022-05-13 3:34 ` [PATCH v2 3/5] dt-bindings: arm/npcm: Add dt-bindings for Graphics Core Information Marvin Lin
2022-05-13 3:34 ` [PATCH v2 4/5] media: Add HEXTILE compressed format Marvin Lin
2022-05-13 3:34 ` [PATCH v2 5/5] drivers: media: platform: Add NPCM Video Capture/Encode Engine driver Marvin Lin
2022-05-13 5:46 ` Paul Menzel
2022-05-17 2:59 ` Kun-Fa Lin
2022-06-06 2:42 ` Kun-Fa Lin
2022-05-13 9:09 ` kernel test robot
2022-05-13 10:30 ` kernel test robot
2022-05-14 10:41 ` kernel test robot
2022-05-17 13:30 ` Jonathan Neuschäfer [this message]
2022-05-19 5:39 ` Kun-Fa Lin
2022-05-19 10:12 ` Jonathan Neuschäfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoOje2L13q7d7KeI@latitude \
--to=j.neuschaefer@gmx.net \
--cc=avifishman70@gmail.com \
--cc=kflin@nuvoton.com \
--cc=kwliu@nuvoton.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=milkfafa@gmail.com \
--cc=openbmc@lists.ozlabs.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox