From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Shevchenko <andy@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v2 1/2] pinctrl: intel: make irq_chip immutable
Date: Wed, 18 May 2022 08:08:17 +0300 [thread overview]
Message-ID: <YoR/QXuS+VlLVWto@lahna> (raw)
In-Reply-To: <20220517163820.86768-1-andriy.shevchenko@linux.intel.com>
On Tue, May 17, 2022 at 07:38:19PM +0300, Andy Shevchenko wrote:
> +static const struct irq_chip intel_gpio_irq_chip = {
> + .name = "intel-gpio",
> + .irq_ack = intel_gpio_irq_ack,
> + .irq_mask = intel_gpio_irq_mask,
> + .irq_unmask = intel_gpio_irq_unmask,
> + .irq_set_type = intel_gpio_irq_type,
> + .irq_set_wake = intel_gpio_irq_wake,
> + .flags = IRQCHIP_MASK_ON_SUSPEND | IRQCHIP_IMMUTABLE,
> + GPIOCHIP_IRQ_RESOURCE_HELPERS,
> +};
You still have the inconsistent alignment here.
next prev parent reply other threads:[~2022-05-18 5:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 16:38 [PATCH v2 1/2] pinctrl: intel: make irq_chip immutable Andy Shevchenko
2022-05-17 16:38 ` [PATCH v2 2/2] pinctrl: intel: Drop unsued irqchip member in struct intel_pinctrl Andy Shevchenko
2022-05-18 5:08 ` Mika Westerberg [this message]
2022-05-18 8:46 ` [PATCH v2 1/2] pinctrl: intel: make irq_chip immutable Andy Shevchenko
2022-05-18 9:19 ` Mika Westerberg
2022-05-18 10:05 ` Andy Shevchenko
2022-05-18 10:11 ` Mika Westerberg
2022-05-18 14:34 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoR/QXuS+VlLVWto@lahna \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox