From: Christoph Hellwig <hch@infradead.org>
To: Donghai Qiao <dqiao@redhat.com>
Cc: akpm@linux-foundation.org, sfr@canb.auug.org.au, arnd@arndb.de,
peterz@infradead.org, heying24@huawei.com,
andriy.shevchenko@linux.intel.com, axboe@kernel.dk,
rdunlap@infradead.org, tglx@linutronix.de, gor@linux.ibm.com,
donghai.w.qiao@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 00/11] smp: cross CPU call interface
Date: Wed, 18 May 2022 02:04:43 -0700 [thread overview]
Message-ID: <YoS2q9a1o123hIGi@infradead.org> (raw)
In-Reply-To: <20220517180326.997129-1-dqiao@redhat.com>
I still haven't seen any good rationale for this. It causes massive
churn just to have more complicated interface (and thus more code)
than before. What is the benefit?
I'm also not sure what is formal about this interface, or why it
should be formal. IPIs should be rare, and we'd better off looking
for instances we can remove entirely.
prev parent reply other threads:[~2022-05-18 9:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 18:03 [PATCH v3 00/11] smp: cross CPU call interface Donghai Qiao
2022-05-17 18:03 ` [PATCH v3 01/11] smp: consolidate the structure definitions to smp.h Donghai Qiao
2022-05-18 9:02 ` Christoph Hellwig
2022-05-17 18:03 ` [PATCH v3 02/11] smp: the definitions of cross call interface Donghai Qiao
2022-05-17 18:03 ` [PATCH v3 03/11] smp: remove SCF_WAIT and SCF_RUN_LOCAL Donghai Qiao
2022-05-17 18:03 ` [PATCH v3 04/11] smp: replace smp_call_function_single() with smp_call() Donghai Qiao
2022-05-17 18:03 ` [PATCH v3 05/11] smp: replace smp_call_function_single_async with smp_call_csd Donghai Qiao
2022-05-17 18:03 ` [PATCH v3 06/11] smp: use smp_call_csd() from irq_work.c and core.c Donghai Qiao
2022-05-17 18:03 ` [PATCH v3 07/11] smp: eliminate smp_call_function_any Donghai Qiao
2022-05-18 19:39 ` kernel test robot
2022-05-17 18:03 ` [PATCH v3 08/11] smp: replace smp_call_function_many_cond() with __smp_call_mask_cond() Donghai Qiao
2022-05-18 20:09 ` kernel test robot
2022-05-17 18:03 ` [PATCH v3 09/11] smp: replace smp_call_function_single_async with smp_call_csd Donghai Qiao
2022-05-17 18:03 ` [PATCH v3 10/11] smp: replace smp_call_function_single() with smp_call() Donghai Qiao
2022-05-17 18:03 ` [PATCH v3 11/11] smp: up.c to adopt the same format of cross CPU call Donghai Qiao
2022-05-18 6:19 ` [PATCH v3 00/11] smp: cross CPU call interface Sven Schnelle
2022-05-18 9:04 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoS2q9a1o123hIGi@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=donghai.w.qiao@gmail.com \
--cc=dqiao@redhat.com \
--cc=gor@linux.ibm.com \
--cc=heying24@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox