From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F406CC433F5 for ; Wed, 18 May 2022 09:19:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233995AbiERJTW (ORCPT ); Wed, 18 May 2022 05:19:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233660AbiERJTV (ORCPT ); Wed, 18 May 2022 05:19:21 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E81E42D1CC; Wed, 18 May 2022 02:19:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652865560; x=1684401560; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=K4vHAuot1/wnt2e2b1J2hjTc823BIiYYt7U1IpgjCpw=; b=PgPDbHVewK8+U5w+QIWOJoPw2/vqY5GAPsuf0fIUJLLrePXG+xcj3RyH 20XG3fKwpUad7eKPAbdjQ1lt5y74LYWwyrux6/jpgrvCESaWCqCzHu4dY 2epSnzmUMxf57WfZszlJot+SoImYn/tzbIJ6ogItbl7URDXFuJ1eCSoXb mA4dOu+uDdbIDIuKnqK1vtjEBnIE7uvMrqQRMUoShbo+NCgQd0ouI5Wbm LE2fVL1R7uWC4vDhu7NcJdyCecsCIhpAtvMAvlCn2gk058ChWBcEdos9e r7HltvLMycZw16LPY8Tdsx41/bOznuaEfAozYLdQNpn6jnKHKGmmE9XXg Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10350"; a="259144766" X-IronPort-AV: E=Sophos;i="5.91,234,1647327600"; d="scan'208";a="259144766" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2022 02:19:19 -0700 X-IronPort-AV: E=Sophos;i="5.91,234,1647327600"; d="scan'208";a="742234478" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.162]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2022 02:19:16 -0700 Received: by lahna (sSMTP sendmail emulation); Wed, 18 May 2022 12:19:14 +0300 Date: Wed, 18 May 2022 12:19:14 +0300 From: Mika Westerberg To: Andy Shevchenko Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Linus Walleij Subject: Re: [PATCH v2 1/2] pinctrl: intel: make irq_chip immutable Message-ID: References: <20220517163820.86768-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 18, 2022 at 11:46:06AM +0300, Andy Shevchenko wrote: > On Wed, May 18, 2022 at 08:08:17AM +0300, Mika Westerberg wrote: > > On Tue, May 17, 2022 at 07:38:19PM +0300, Andy Shevchenko wrote: > > > +static const struct irq_chip intel_gpio_irq_chip = { > > > + .name = "intel-gpio", > > > + .irq_ack = intel_gpio_irq_ack, > > > + .irq_mask = intel_gpio_irq_mask, > > > + .irq_unmask = intel_gpio_irq_unmask, > > > + .irq_set_type = intel_gpio_irq_type, > > > + .irq_set_wake = intel_gpio_irq_wake, > > > + .flags = IRQCHIP_MASK_ON_SUSPEND | IRQCHIP_IMMUTABLE, > > > + GPIOCHIP_IRQ_RESOURCE_HELPERS, > > > +}; > > > > You still have the inconsistent alignment here. > > I'm not sure what problem do you see. I mean the tab alignment you use: .name = "intel-gpio", .irq_ack = intel_gpio_irq_ack, .irq_mask = intel_gpio_irq_mask, .irq_unmask = intel_gpio_irq_unmask, .irq_set_type = intel_gpio_irq_type, .irq_set_wake = intel_gpio_irq_wake, All the other struct initializations in the driver use this style (and I prefer it too): .name = "intel-gpio", .irq_ack = intel_gpio_irq_ack, .irq_mask = intel_gpio_irq_mask, .irq_unmask = intel_gpio_irq_unmask, .irq_set_type = intel_gpio_irq_type, .irq_set_wake = intel_gpio_irq_wake, Hope this explains.