Re: [RFC PATCH] printk: console: Allow each console to have its own loglevel

Greg Kroah-Hartman
2022-05-19T17:45:38Z

On Thu, May 19, 2022 at 04:55:08PM +0100, Chris Down wrote:
> Greg Kroah-Hartman writes:
> > On Thu, May 19, 2022 at 04:08:04PM +0100, Chris Down wrote:
> > > Greg Kroah-Hartman writes:
> > > > > struct console {
> > > > > char name[16];
> > > > > void (*write)(struct console *, const char *, unsigned);
> > > > > @@ -179,9 +173,11 @@ struct console {
> > > > > void *data;
> > > > > struct console *next;
> > > > > int level;
> > > > > - struct device classdev;
> > > > > + struct device *classdev;
> > > >
> > > > Ick, no, keep the real structure here. It can properly handle the
> > > > reference counting for the object. Just correctly clean up in the
> > > > release function, not anywhere else.
> > >
> > > Sorry, I'm getting more and more confused about what you're asking me to do,
> > > and less and less clear on the rationale.
> > >
> > > Can you please clarify what "correctly cleaning up" would mean for a
> > > non-pointer `struct device'?
> > >
> > > Is your concern that...
> > >
> > > register_console(c)
> > > device_initialize(c->d)
> > > device_add(c->d)
> > > unregister_console(c)
> > > device_unregister(c->d) console_classdev_release(c->d)
> > > register_console(c)
> > > device_initialize(c->d) <-- classdev was not previously zeroed out
> > > in console_classdev_release() and bad things may happen
> >
> > Note, you can not "recycle" a structure in the driver model. So when
> > the console is unregistered, it should be freed. When it is registered,
> > it should be created. Perhaps that is the confusion here?
>
> I suspect you're close to the source of the confusion. So your point is that
> the `struct console' should be freed when the driver refcount drops to 0
> rather than trying to do it the other way around. Right?

When the "device" refcount, not driver. refcounts are for data.

> So, just to try to come to a solution, here's the lay of the land as I
> understand it. Currently pretty much all consoles are statically defined
> (and most of the non-static cases are false positives)
>
> % git grep 'struct console.*=' -- '*.c' | awk '/static/ { print "static"; } !/static/ { print "non-static" }' | sort | uniq -c
> 15 non-static
> 105 static

ah, ok, then we have a problem, and your change to the struct device
being a pointer is correct.

That's the problem when you only see a tiny bit of the kernel in a
patch, sorry for the confusion.

But you still need to free the device structure that is pointed to by
the device in the release function. Your release function can not be
"empty" like your original patch was.

thanks,

greg k-h