Re: [PATCH v9 1/3] ARM: dts: nuvoton: Add memory controller node

Medad Young
2022-05-24T01:16:09Z

Dear Borislav,

thanks for your help.

Borislav Petkov <bp@alien8.de> 於 2022年5月23日 週一 下午5:34寫道：
>
> On Mon, May 23, 2022 at 05:06:07PM +0800, Medad Young wrote:
> > I did do "git commit --amend",
> > I beleve the issue is about the mail server I used,
> > I use gmail to send the mail due to the mail server of my company
> > does't support smtp
> > so now I should sign the commit with my gmail account.
>
> No, you should supply --author too - I had forgotten about that.
>
> commit 0876b99e4aa2bf7113070c9c0f5d0ade7ad91697 (HEAD -> refs/heads/test)
> Author: Medad CChien <medadyoung@gmail.com>
> Date: Tue May 10 11:10:54 2022 +0800
>
> ARM: dts: nuvoton: Add memory controller node
>
> ECC must be configured in the BootBlock header.
> Then, you can read error counts via the EDAC kernel framework.
>
> Signed-off-by: Medad CChien <ctcchien@nuvoton.com>
>
> $ git commit --amend --author="Medad CChien <ctcchien@nuvoton.com>"
> [test 5d6cd85171d1] ARM: dts: nuvoton: Add memory controller node
> Author: Medad CChien <ctcchien@nuvoton.com>
> Date: Tue May 10 11:10:54 2022 +0800
> 1 file changed, 7 insertions(+)
> $ git log -p -1
> commit 5d6cd85171d14e67840e672e2f96a16981243424 (HEAD -> refs/heads/test)
> Author: Medad CChien <ctcchien@nuvoton.com>
> Date: Tue May 10 11:10:54 2022 +0800
>
> ARM: dts: nuvoton: Add memory controller node
>
> ECC must be configured in the BootBlock header.
> Then, you can read error counts via the EDAC kernel framework.
>
> Signed-off-by: Medad CChien <ctcchien@nuvoton.com>
>
> $ git format-patch -1 -o /tmp/
> /tmp/0001-ARM-dts-nuvoton-Add-memory-controller-node.patch
>
> $ head /tmp/0001-ARM-dts-nuvoton-Add-memory-controller-node.patch
> From 5d6cd85171d14e67840e672e2f96a16981243424 Mon Sep 17 00:00:00 2001
> From: Medad CChien <ctcchien@nuvoton.com>
> ^^^^^^^^^^^^^^^^^^^^^^
>
>
> Don't hesitate to look at the manpages if a tool doesn't do what you
> expect it to do.

OK, I will try to supply --author with my original mail server

>
> HTH.
>
> --
> Regards/Gruss,
> Boris.
>
> https://people.kernel.org/tglx/notes-about-netiquette

B.R.
Medad