public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	X86 ML <x86@kernel.org>, Tony Luck <tony.luck@intel.com>
Subject: [PATCH] platform/x86/intel/ifs: Add CPU_SUP_INTEL dependency
Date: Thu, 19 May 2022 16:57:15 +0200	[thread overview]
Message-ID: <YoZay8YR0zRGyVu+@zn.tnic> (raw)
In-Reply-To: <YoZaZ+HVyjKrwtSQ@zn.tnic>

From: Borislav Petkov <bp@suse.de>

The driver is using functions from a compilation unit which is enabled
by CONFIG_CPU_SUP_INTEL. Add that dependency to Kconfig explicitly
otherwise:

  drivers/platform/x86/intel/ifs/load.o: in function `ifs_load_firmware':
  load.c:(.text+0x3b8): undefined reference to `intel_cpu_collect_info'

Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Borislav Petkov <bp@suse.de>
---
 drivers/platform/x86/intel/ifs/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/intel/ifs/Kconfig b/drivers/platform/x86/intel/ifs/Kconfig
index d84491cfb0db..7ce896434b8f 100644
--- a/drivers/platform/x86/intel/ifs/Kconfig
+++ b/drivers/platform/x86/intel/ifs/Kconfig
@@ -1,6 +1,6 @@
 config INTEL_IFS
 	tristate "Intel In Field Scan"
-	depends on X86 && 64BIT && SMP
+	depends on X86 && CPU_SUP_INTEL && 64BIT && SMP
 	select INTEL_IFS_DEVICE
 	help
 	  Enable support for the In Field Scan capability in select
-- 
2.35.1

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

  reply	other threads:[~2022-05-19 14:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-18 10:29 linux-next: Tree for May 18 Stephen Rothwell
2022-05-18 21:05 ` linux-next: Tree for May 18 (arch/x86/kernel/cpu/microcode/intel.o) Randy Dunlap
2022-05-18 21:34   ` Borislav Petkov
2022-05-18 21:54     ` Randy Dunlap
2022-05-18 22:29       ` Borislav Petkov
2022-05-18 22:40         ` Randy Dunlap
2022-05-19 14:55           ` Borislav Petkov
2022-05-19 14:57             ` Borislav Petkov [this message]
2022-05-19 17:47               ` [PATCH] platform/x86/intel/ifs: Add CPU_SUP_INTEL dependency Hans de Goede
2022-05-19 15:03             ` [PATCH] x86/microcode: Add explicit CPU vendor dependency Borislav Petkov
2022-05-20  9:34   ` [tip: x86/microcode] " tip-bot2 for Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YoZay8YR0zRGyVu+@zn.tnic \
    --to=bp@alien8.de \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=sfr@canb.auug.org.au \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox