From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Miguel Ojeda <ojeda@kernel.org>,
rust-for-linux <rust-for-linux@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Masahiro Yamada <masahiroy@kernel.org>, Li Li <dualli@google.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Wedson Almeida Filho <wedsonaf@google.com>
Subject: Re: [PATCH v2] binder: convert `BINDER_*` ioctl `#define`s into an `enum`
Date: Thu, 19 May 2022 17:50:58 +0200 [thread overview]
Message-ID: <YoZnYkRjC+TfdB1i@kroah.com> (raw)
In-Reply-To: <CANiq72=4YKUoUjbs3484mdjsDCXX1V6qf8MrzhW0FN3ZbbDaAg@mail.gmail.com>
On Wed, May 18, 2022 at 03:39:42PM +0200, Miguel Ojeda wrote:
> Hi Greg,
>
> On Tue, May 17, 2022 at 12:28 PM Miguel Ojeda <ojeda@kernel.org> wrote:
> >
> > bindgen (a tool which generates the "raw" C bindings for Rust) only
> > works (so far) with "simple" C `#define`s. In order to avoid having
> > to manually maintain these constants in the (potential) Rust side,
> > this patch converts them into an `enum`.
>
> Given the discussion in v1's thread [0], I think we should hold on
> applying the patch (just letting you know here in v2).
>
> [0] https://lore.kernel.org/lkml/CANiq72=_UAF5DRHCmW4qNt-Wi3yV6vPEjdLhBTijG_ZGgfpaTA@mail.gmail.com/
>
> Cheers,
> Miguel
Yeah, I'll drop this from my queue, sorry.
greg k-h
prev parent reply other threads:[~2022-05-19 15:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 10:28 [PATCH v2] binder: convert `BINDER_*` ioctl `#define`s into an `enum` Miguel Ojeda
2022-05-18 13:39 ` Miguel Ojeda
2022-05-19 15:50 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoZnYkRjC+TfdB1i@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=dualli@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=wedsonaf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox