Re: [PATCH v2 2/2] dmaengine: mediatek-cqdma: Add support for MediaTek MT6795

Vinod Koul
2022-05-19T18:02:24Z

On 03-05-22, 16:06, AngeloGioacchino Del Regno wrote:
> Add a compatible string and platform data for the Helio X10 MT6795 SoC.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> drivers/dma/mediatek/mtk-cqdma.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/dma/mediatek/mtk-cqdma.c b/drivers/dma/mediatek/mtk-cqdma.c
> index a2fb538d9483..e1772dbf50d5 100644
> --- a/drivers/dma/mediatek/mtk-cqdma.c
> +++ b/drivers/dma/mediatek/mtk-cqdma.c
> @@ -757,8 +757,14 @@ static const struct mtk_cqdma_plat_data cqdma_mt6765 = {
> .reg_src2 = 0x60,
> };
>
> +static const struct mtk_cqdma_plat_data cqdma_mt6795 = {
> + .reg_dst2 = 0x44,
> + .reg_src2 = 0x40,

Please define these registers

> +};
> +
> static const struct of_device_id mtk_cqdma_match[] = {
> { .compatible = "mediatek,mt6765-cqdma", .data = &cqdma_mt6765 },
> + { .compatible = "mediatek,mt6795-cqdma", .data = &cqdma_mt6795 },

where is this documented?

> { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(of, mtk_cqdma_match);
> --
> 2.35.1

--
~Vinod