From: Andrew Lunn <andrew@lunn.ch>
To: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
Cc: michael@amarulasolutions.com,
alberto.bianchi@amarulasolutions.com,
linux-amarula@amarulasolutions.com, linuxfancy@googlegroups.com,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: phy: DP83822: enable rgmii mode if phy_interface_is_rgmii
Date: Thu, 19 May 2022 21:02:22 +0200 [thread overview]
Message-ID: <YoaUPvwccJZ6vT/S@lunn.ch> (raw)
In-Reply-To: <20220519185057.1657115-1-tommaso.merciai@amarulasolutions.com>
On Thu, May 19, 2022 at 08:50:56PM +0200, Tommaso Merciai wrote:
> RGMII mode can be enable from dp83822 straps, and also writing bit 9
> of register 0x17 - RMII and Status Register (RCSR).
> When phy_interface_is_rgmii rgmii mode must be enabled, same for
> contrary, this prevents malconfigurations of hw straps
>
> References:
> - https://www.ti.com/lit/gpn/dp83822i p66
>
> Signed-off-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
> Co-developed-by: Michael Trimarchi <michael@amarulasolutions.com>
> Suggested-by: Alberto Bianchi <alberto.bianchi@amarulasolutions.com>
> Tested-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
> ---
> Changes since v1:
> - Improve commit msg
> - Add definition of bit 9 reg rcsr (rgmii mode en)
> - Handle case: phy_interface_is_rgmii is false
Please don't post a new version for at least 24 hours. Give people
time to review the code and make comments.
Andrew
prev parent reply other threads:[~2022-05-19 19:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 18:50 [PATCH v2] net: phy: DP83822: enable rgmii mode if phy_interface_is_rgmii Tommaso Merciai
2022-05-19 18:53 ` Michael Nazzareno Trimarchi
2022-05-19 19:02 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoaUPvwccJZ6vT/S@lunn.ch \
--to=andrew@lunn.ch \
--cc=alberto.bianchi@amarulasolutions.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxfancy@googlegroups.com \
--cc=michael@amarulasolutions.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tommaso.merciai@amarulasolutions.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox