From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 447A1C433EF for ; Thu, 19 May 2022 23:39:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343640AbiESXje (ORCPT ); Thu, 19 May 2022 19:39:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236252AbiESXjc (ORCPT ); Thu, 19 May 2022 19:39:32 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5647ED78E for ; Thu, 19 May 2022 16:39:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3F877617FF for ; Thu, 19 May 2022 23:39:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1DE52C385AA; Thu, 19 May 2022 23:39:30 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="C1I8xTFf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1653003568; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=edjvbY7HX7Lcrbc+aJx5o8Hn+MKLeaVB2jN9HDZFfS8=; b=C1I8xTFfxz9WdxLF7BHNwQYRMHm820W30KjpGT5tD45asjE/7Mm5FF/tXJXCBmz/3gSihm TeXVwRaz0kP5J7s+A+b1NXyipneBaoXKpItUMT/rDY8CtMn1WPO/Xyw4pypV5LpddU09xA F6z2T+piJkJLldQB67E8TKhsn4IFJDo= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 0ad65c0f (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Thu, 19 May 2022 23:39:28 +0000 (UTC) Date: Fri, 20 May 2022 01:39:26 +0200 From: "Jason A. Donenfeld" To: Jens Axboe Cc: Theodore Ts'o , Christoph Hellwig , LKML Subject: Re: [PATCHSET 0/2] Fix splice from random/urandom Message-ID: References: <20220519193133.194138-1-axboe@kernel.dk> <8e6c98d4-03e9-3eb5-3d4e-b9a9faeb677a@kernel.dk> <60b82026-9c46-16ea-d9fa-05eb96ae2218@kernel.dk> <3bcbfde4-3247-b4ff-9a7c-963a9a510703@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <3bcbfde4-3247-b4ff-9a7c-963a9a510703@kernel.dk> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jens, On Thu, May 19, 2022 at 05:33:01PM -0600, Jens Axboe wrote: > On 5/19/22 5:25 PM, Jason A. Donenfeld wrote: > > Hi Jens, > > > > On Fri, May 20, 2022 at 1:22 AM Jens Axboe wrote: > >> I can certainly do the write side too. To fix this regression, I just > >> valued doing read_iter first and I'd hate to hold that up to do the > >> write side too. I'll do the write side later today, but let's keep them > >> separate. > > > > Excellent, thanks. I plan to queue these up all in a row. > > Built and tested v2, just sent it out. Note that it deviates from your > proposal a bit since with that we lost the > > if (!len) > break; > > check, which is kind of important if you ever want to be done :-) Heh, noticed that too, thanks. > I'll do the write_iter side, but as mentioned, I'd prefer to keep it > separate from this patchset as this one fixes a real regression that we > need to get backported too. No problem. Because of all the flux in random.c lately, I've been preparing a massive backports branch, 2 branches actually, so I'll make sure this is in there. Backport concern aside, though, I'll look for your write_iter patch today. Thanks a bunch for doing this. Jason