From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F225DC433F5 for ; Sat, 21 May 2022 00:31:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354227AbiEUAbz (ORCPT ); Fri, 20 May 2022 20:31:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231552AbiEUAbv (ORCPT ); Fri, 20 May 2022 20:31:51 -0400 Received: from out1.migadu.com (out1.migadu.com [91.121.223.63]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DCE91966A0 for ; Fri, 20 May 2022 17:31:50 -0700 (PDT) Date: Fri, 20 May 2022 17:31:43 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1653093108; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/PvswcI13Yf4q0l94RXQB7xvET7jRmzJANLdVyC6U+A=; b=BZxSssMM56O+65UCUfQpz9fJkEhid3CADJGmnG88vw0ZXU6GVY5FCSTCnUZRxyQSJ9nhcC 1kJLsZoU+x8BW/bPXcJo/CH4BMxdIIwFlZSOvK3zy/VshPgDCFgrVFx56VW9IGkMdBxAFS bEXLmD1vJthOX2YMbMW5txVXPs06K1s= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Kent Overstreet Cc: Andrew Morton , linux-mm@kvack.org, Dave Chinner , linux-kernel@vger.kernel.org, Hillf Danton , Christophe JAILLET Subject: Re: [PATCH v3 3/6] mm: shrinkers: provide shrinkers with names Message-ID: References: <20220509183820.573666-1-roman.gushchin@linux.dev> <20220509183820.573666-4-roman.gushchin@linux.dev> <20220520164115.oectf3x5hkwesioi@moria.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220520164115.oectf3x5hkwesioi@moria.home.lan> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 20, 2022 at 12:41:15PM -0400, Kent Overstreet wrote: > On Mon, May 09, 2022 at 11:38:17AM -0700, Roman Gushchin wrote: > > diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c > > index ad9f16689419..c1f734ab86b3 100644 > > --- a/drivers/md/bcache/btree.c > > +++ b/drivers/md/bcache/btree.c > > @@ -812,7 +812,7 @@ int bch_btree_cache_alloc(struct cache_set *c) > > c->shrink.seeks = 4; > > c->shrink.batch = c->btree_pages * 2; > > > > - if (register_shrinker(&c->shrink)) > > + if (register_shrinker(&c->shrink, "btree")) > > pr_warn("bcache: %s: could not register shrinker\n", > > __func__); > > These drivers need better names for their shrinkers - there will often be > multiple instances in use on a system and we need to distinguish. > > Also, "btree" isn't a good name for the bcache shrinker - "bcache-%pU", > c->set_uuid would be a good name for bcache's shrinker, it'll match up with the > cache set directory in /sys/fs/bcache/. Sure, will improve in the next version. Thanks! > > For others (device mapper, md, etc.) there should be a minor device number you > can reference. Good point, will think of it. Thank you for taking a look!