From: Chris Down <chris@chrisdown.name>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
John Ogness <john.ogness@linutronix.de>,
Geert Uytterhoeven <geert@linux-m68k.org>,
kernel-team@fb.com
Subject: Re: [RFC PATCH v2] printk: console: Allow each console to have its own loglevel
Date: Sat, 21 May 2022 20:23:06 +0100 [thread overview]
Message-ID: <Yok8GtbfXkc1E0PR@chrisdown.name> (raw)
In-Reply-To: <Yok0yjx0aKvlgoIL@kroah.com>
Greg Kroah-Hartman writes:
>You forgot what changed from v1 :(
Whoops! I must have accidentally nuked it when writing the mail.
The list should be:
- Dynamically allocate struct device*
- Document sysfs attributes in Documentation/ABI/
- Use sysfs_emit() instead of sprintf() in dev sysfs files
- Remove WARN_ON() for device_add/IS_ERR(console_class)
- Remove "soon" comment for kernel.printk, wait to discuss timeline with Petr
- Fix !CONFIG_PRINTK build
- Fix device_unregister() NULL dereference if called before class setup
- Add new documentation to MAINTAINERS
>Anyway, the driver model interaction looks good to me, nice work, no
>objections at all.
Great, thanks for checking it over :-)
next prev parent reply other threads:[~2022-05-21 19:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 12:57 [RFC PATCH v2] printk: console: Allow each console to have its own loglevel Chris Down
2022-05-20 16:06 ` Rik van Riel
2022-07-07 14:38 ` Petr Mladek
2022-07-13 14:32 ` Chris Down
2022-05-21 18:51 ` Greg Kroah-Hartman
2022-05-21 19:23 ` Chris Down [this message]
2022-05-23 13:09 ` Vincent Whitchurch
2022-05-23 14:24 ` Chris Down
2022-06-16 15:57 ` Chris Down
2022-07-08 15:23 ` design: was: " Petr Mladek
2022-07-08 19:04 ` John Ogness
2022-07-11 8:32 ` Petr Mladek
2022-07-11 10:17 ` Sergey Senozhatsky
2022-07-13 14:50 ` Chris Down
2022-07-13 14:49 ` Chris Down
2022-07-14 15:44 ` Petr Mladek
2022-07-15 12:49 ` Petr Mladek
2022-07-15 13:00 ` Chris Down
2022-07-19 12:11 ` Chris Down
2022-07-19 13:00 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yok8GtbfXkc1E0PR@chrisdown.name \
--to=chris@chrisdown.name \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.ogness@linutronix.de \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox