Re: [PATCH v3 0/4] simatic-ipc additions to p2sb apl lake gpio

Henning Schild
2022-06-07T16:15:30Z

Am Tue, 7 Jun 2022 18:18:05 +0300
schrieb Andy Shevchenko <andriy.shevchenko@linux.intel.com>:

> On Mon, May 23, 2022 at 07:24:08PM +0300, Andy Shevchenko wrote:
> > On Fri, May 13, 2022 at 10:36:48AM +0200, Henning Schild wrote:
> > > changed since v2:
> > > - put GPIO led module under same config switch
> > > - some style changes from review
> > > - init gpios with gpiod_get_index and drop gpiod_set_value
> > > - drop bogus "if" from watchdog Kconfig
> > >
> > > changed since v1:
> > > - rebased
> > > - split p1 into p1-3
> > >
> > > This switches the simatic-ipc modules to using the upcoming p2sb
> > > interface introduced by Andy with
> > > "platform/x86: introduce p2sb_bar() helper".
> > > The series relies on these p2sb changes already applied and Andy
> > > will likely take them into his series at some point.
> > >
> > > It also switches to one apollo lake device to using gpio leds.
> >
> > Hmm... This series misses LEDS maintainer. Okay, I will include
> > them when sending v6 after v5.19-rc1.
>
> I have sent v6 [1], please make sure everything is okay.

I received that and had a quick look over my bits. That all looked like
i sent it so i have no reason to doubt it would be working as expected.

In the coming two weeks i will not be able to get my hands on hardware,
so can not test but am pretty sure it is not needed another time.

regards,
Henning

> [1]:
> https://lore.kernel.org/platform-driver-x86/20220606164138.66535-1-andriy.shevchenko@linux.intel.com/