From: Uladzislau Rezki <urezki@gmail.com>
To: Baoquan He <bhe@redhat.com>
Cc: akpm@linux-foundation.org, npiggin@gmail.com, urezki@gmail.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] mm/vmalloc: fix typo in local variable name
Date: Mon, 6 Jun 2022 22:47:35 +0200 [thread overview]
Message-ID: <Yp5n58uecTlSro6f@pc638.lan> (raw)
In-Reply-To: <20220606083909.363350-4-bhe@redhat.com>
On Mon, Jun 06, 2022 at 04:39:07PM +0800, Baoquan He wrote:
> In __purge_vmap_area_lazy(), rename local_pure_list to local_purge_list.
>
> Signed-off-by: Baoquan He <bhe@redhat.com>
> ---
> mm/vmalloc.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index c7e1634ff2b9..11dfc897de40 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -1673,32 +1673,32 @@ static void purge_fragmented_blocks_allcpus(void);
> static bool __purge_vmap_area_lazy(unsigned long start, unsigned long end)
> {
> unsigned long resched_threshold;
> - struct list_head local_pure_list;
> + struct list_head local_purge_list;
> struct vmap_area *va, *n_va;
>
> lockdep_assert_held(&vmap_purge_lock);
>
> spin_lock(&purge_vmap_area_lock);
> purge_vmap_area_root = RB_ROOT;
> - list_replace_init(&purge_vmap_area_list, &local_pure_list);
> + list_replace_init(&purge_vmap_area_list, &local_purge_list);
> spin_unlock(&purge_vmap_area_lock);
>
> - if (unlikely(list_empty(&local_pure_list)))
> + if (unlikely(list_empty(&local_purge_list)))
> return false;
>
> start = min(start,
> - list_first_entry(&local_pure_list,
> + list_first_entry(&local_purge_list,
> struct vmap_area, list)->va_start);
>
> end = max(end,
> - list_last_entry(&local_pure_list,
> + list_last_entry(&local_purge_list,
> struct vmap_area, list)->va_end);
>
> flush_tlb_kernel_range(start, end);
> resched_threshold = lazy_max_pages() << 1;
>
> spin_lock(&free_vmap_area_lock);
> - list_for_each_entry_safe(va, n_va, &local_pure_list, list) {
> + list_for_each_entry_safe(va, n_va, &local_purge_list, list) {
> unsigned long nr = (va->va_end - va->va_start) >> PAGE_SHIFT;
> unsigned long orig_start = va->va_start;
> unsigned long orig_end = va->va_end;
> --
> 2.34.1
>
Makes sense to me: Reviewed-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
--
Uladzislau Rezki
next prev parent reply other threads:[~2022-06-06 20:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 8:39 [PATCH 0/5] Cleanup patches of vmalloc Baoquan He
2022-06-06 8:39 ` [PATCH 1/5] mm/vmalloc: remove the unnecessary type check Baoquan He
2022-06-06 20:36 ` Uladzislau Rezki
2022-06-06 23:34 ` Baoquan He
2022-06-06 8:39 ` [PATCH 2/5] mm/vmalloc: remove the redundant boundary check Baoquan He
2022-06-06 20:46 ` Uladzislau Rezki
2022-06-06 8:39 ` [PATCH 3/5] mm/vmalloc: fix typo in local variable name Baoquan He
2022-06-06 20:47 ` Uladzislau Rezki [this message]
2022-06-06 8:39 ` [PATCH 4/5] mm/vmalloc: Add code comment for find_vmap_area_exceed_addr() Baoquan He
2022-06-06 20:50 ` Uladzislau Rezki
2022-06-06 8:39 ` [PATCH 5/5] mm: ioremap: rename ioremap_page_range() to ioremap_range() Baoquan He
2022-06-07 5:27 ` Christoph Hellwig
2022-06-07 7:53 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yp5n58uecTlSro6f@pc638.lan \
--to=urezki@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox