From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB1A5C43334 for ; Tue, 7 Jun 2022 09:46:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239861AbiFGJqM (ORCPT ); Tue, 7 Jun 2022 05:46:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234715AbiFGJqG (ORCPT ); Tue, 7 Jun 2022 05:46:06 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB0E1E64DB; Tue, 7 Jun 2022 02:46:02 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9004821B7A; Tue, 7 Jun 2022 09:46:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1654595161; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7MSzLpvdj4J16D8mZWCR6FzSRkCoMkGtMMDOn4haUiU=; b=cgaiqxAaG+nF69jX8yA+BXHJupOM/6qMqNN0IiLMDUSHbsUFXm2nyV5sUFrYaI/NBZTSA2 4QMKNQSBOmBQjKc6fd4RzDQc2WxJ1luimb6yYW3ZPwhQHiQxReOO3jSFOfrBvXda4FuHAi bB33DbNMKbBlobHXqS4qg58a73+P+OI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1654595161; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7MSzLpvdj4J16D8mZWCR6FzSRkCoMkGtMMDOn4haUiU=; b=YR8zrD+OLLqasP66ahtxBQb1RTA+cb+tvstppYaP6Bbd9RjbHtApgCVTWwVsajwqKHWE7m 4fnnBVqoaNgBXXDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 399B213638; Tue, 7 Jun 2022 09:46:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 2e1rCVken2LFOwAAMHmgww (envelope-from ); Tue, 07 Jun 2022 09:46:01 +0000 Date: Tue, 7 Jun 2022 11:45:59 +0200 From: Vasant Karasulli To: Borislav Petkov Cc: linux-kernel@vger.kernel.org, jroedel@suse.de, kvm@vger.kernel.org, x86@kernel.org, thomas.lendacky@amd.com, varad.gautam@suse.com Subject: Re: [PATCH v6 1/4] x86/tests: Add tests for AMD SEV-ES #VC handling Message-ID: References: <20220318104646.8313-1-vkarasulli@suse.de> <20220318104646.8313-2-vkarasulli@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fr 08-04-22 15:44:26, Borislav Petkov wrote: > > Subject: Re: [PATCH v6 1/4] x86/tests: Add tests for AMD SEV-ES #VC handling > > > diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile > > index 6aef9ee28a39..69472a576909 100644 > > --- a/arch/x86/kernel/Makefile > > +++ b/arch/x86/kernel/Makefile > > @@ -24,6 +24,13 @@ CFLAGS_REMOVE_sev.o = -pg > > CFLAGS_REMOVE_cc_platform.o = -pg > > endif > > > > +# AMD_SEV_TEST_VC registers a kprobe by function name. IPA-SRA creates > > +# function copies and renames them to have an .isra suffix, which breaks kprobes' > > +# lookup. Build with -fno-ipa-sra for the test. > > +ifdef CONFIG_AMD_SEV_TEST_VC > > Why ifdef? > > I think you want this to be enabled unconditionally since the VC tests > select KRPOBES. > VC tests added in this patch series depend on the configuration option CONFIG_AMD_SEV_TEST_VC which in turn selects KPROBES. I think compiler flag -fno-ipa-sra wouldn't be necessary if configuration option CONFIG_AMD_SEV_TEST_VC is disabled. > > +CFLAGS_sev.o += -fno-ipa-sra > > +endif > > + > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette -- Vasant Karasulli Kernel generalist www.suse.com [https://www.suse.com/assets/img/social-platforms-suse-logo.png] SUSE - Open Source Solutions for Enterprise Servers & Cloud Modernize your infrastructure with SUSE Linux Enterprise servers, cloud technology for IaaS, and SUSE's software-defined storage. www.suse.com