From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 839AACCA47C for ; Tue, 7 Jun 2022 10:07:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240621AbiFGKHJ (ORCPT ); Tue, 7 Jun 2022 06:07:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233877AbiFGKHE (ORCPT ); Tue, 7 Jun 2022 06:07:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69218EACD7; Tue, 7 Jun 2022 03:07:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 04495611E8; Tue, 7 Jun 2022 10:07:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84B2EC385A5; Tue, 7 Jun 2022 10:07:00 +0000 (UTC) Date: Tue, 7 Jun 2022 11:06:56 +0100 From: Catalin Marinas To: "Jason A. Donenfeld" Cc: Phil Elwell , Russell King - ARM Linux , Russell King , linux-arm-kernel , LKML , Stephen Boyd , Ard Biesheuvel , stable Subject: Re: [PATCH v2] ARM: initialize jump labels before setup_machine_fdt() Message-ID: References: <8cc7ebe4-442b-a24b-9bb0-fce6e0425ee6@raspberrypi.com> <0f6458d7-037a-fa4d-8387-7de833288fb9@raspberrypi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jason, On Tue, Jun 07, 2022 at 10:51:41AM +0200, Jason A. Donenfeld wrote: > On Tue, Jun 7, 2022 at 10:47 AM Phil Elwell wrote: > > Thanks for the quick response, but that doesn't work for me either. Let me say > > again that I'm on a downstream kernel (rpi-5.15.y) so this may not be a > > universal problem, but merging either of these fixing patches would be fatal for us. > > Alright, thanks. And I'm guessing you don't currently have a problem > *without* either of the fixing patches, because your device tree > doesn't use rng-seed. Is that right? > > In anycase, I sent in a revert to get all the static branch stuff out > of stable -- https://lore.kernel.org/stable/20220607084005.666059-1-Jason@zx2c4.com/ > -- so the "urgency" of this should decrease and we can fix this as > normal during the 5.19 cycle. Since the above revert got queued in -stable, I assume you don't need commit 73e2d827a501 ("arm64: Initialize jump labels before setup_machine_fdt()") in stable either. Do you plan to fix the crng_ready() static branch differently? If you do, I'd like to revert the corresponding arm64 commit as well. It seems to be harmless but I'd rather not keep it if no longer needed. So please keep me updated whatever you decide. Thanks. -- Catalin