From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CF15C433EF for ; Tue, 7 Jun 2022 15:57:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344592AbiFGP5z (ORCPT ); Tue, 7 Jun 2022 11:57:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344453AbiFGP5w (ORCPT ); Tue, 7 Jun 2022 11:57:52 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 304BB36B51 for ; Tue, 7 Jun 2022 08:57:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DE2B5B82172 for ; Tue, 7 Jun 2022 15:57:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B988C385A5; Tue, 7 Jun 2022 15:57:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1654617468; bh=iLKqDYEYhp+eqcsdWfLEMP2XRbwgCOgGlSNWpiGM/P4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rp+hwJ7lBcWIuwUeHzey8vwqNYVhq24ImKpakJ/D2RkF/zlJ/8w8vsCidTwGMuUH2 y/msJ314ityDrOSfi/pSz5jq51O6b8RYhgKTMrR+cwrrbjrPUuieogDndoD/ID4ELh UYHu6m+1OFv0JxvjeA78Cdvu0rGS/zxyywTp8444= Date: Tue, 7 Jun 2022 17:57:46 +0200 From: "gregkh@linuxfoundation.org" To: Paris Andrea Cc: "linux-kernel@vger.kernel.org" , "linux-staging@lists.linux.dev" Subject: Re: [PATCH] staging: r8188eu: add multiple blank lines Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 07, 2022 at 01:36:16PM +0000, Paris Andrea wrote: > This patch adds a blank line after three different variable declarations > > in the file rtw_cmd.c in order to fix three related checkpatch warnings. > > > Signed-off-by: Andrea Paris > > --- > Added three blank lines, fixed checkpatch warning > > drivers/staging/r8188eu/core/rtw_cmd.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/staging/r8188eu/core/rtw_cmd.c b/drivers/staging/r8188eu/core/rtw_cmd.c > index 06523d91939a..92d5e4534087 100644 > --- a/drivers/staging/r8188eu/core/rtw_cmd.c > +++ b/drivers/staging/r8188eu/core/rtw_cmd.c > @@ -25,6 +25,7 @@ void rtw_free_evt_priv(struct evt_priv *pevtpriv) > > while (!rtw_cbuf_empty(pevtpriv->c2h_queue)) { > void *c2h = rtw_cbuf_pop(pevtpriv->c2h_queue); > + > if (c2h && c2h != (void *)pevtpriv) > kfree(c2h); > } > @@ -323,6 +324,7 @@ u8 rtw_sitesurvey_cmd(struct adapter *padapter, struct ndis_802_11_ssid *ssid, > /* prepare ssid list */ > if (ssid) { > int i; > + > for (i = 0; i < ssid_num && i < RTW_SSID_SCAN_AMOUNT; i++) { > if (ssid[i].SsidLength) { > memcpy(&psurveyPara->ssid[i], &ssid[i], sizeof(struct ndis_802_11_ssid)); > @@ -334,6 +336,7 @@ u8 rtw_sitesurvey_cmd(struct adapter *padapter, struct ndis_802_11_ssid *ssid, > /* prepare channel list */ > if (ch) { > int i; > + > for (i = 0; i < ch_num && i < RTW_CHANNEL_SCAN_AMOUNT; i++) { > if (ch[i].hw_value && !(ch[i].flags & RTW_IEEE80211_CHAN_DISABLED)) { > memcpy(&psurveyPara->ch[i], &ch[i], sizeof(struct rtw_ieee80211_channel)); > -- > 2.25.1 Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - It looks like you did not use your "real" name for the patch on either the Signed-off-by: line, or the From: line (both of which have to match). Please read the kernel file, Documentation/SubmittingPatches for how to do this correctly. - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot