From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00DD3C43334 for ; Tue, 7 Jun 2022 16:20:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344839AbiFGQUs (ORCPT ); Tue, 7 Jun 2022 12:20:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343753AbiFGQUp (ORCPT ); Tue, 7 Jun 2022 12:20:45 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2556610191B; Tue, 7 Jun 2022 09:20:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B847B617BF; Tue, 7 Jun 2022 16:20:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49B83C385A5; Tue, 7 Jun 2022 16:20:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654618844; bh=l9olBdY8XoPM0wf1tBtpXR5ucJg+To7Pu36qgJqjaqk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NQP8+i8X1y17vNEFOscgQI0w77IuDZF+Fb0YMAmNub+87rZKCbc2s99eyXz5dGYu1 MquzbeVwpnRq5KWaarHllVfoQm8s1AlgXzJqvUk0XOp67mQUfq/PIsNjPWiax2/moO 6DTcoJuGX6paPBFBEA8dGQsb+kZtnaqsL/GuGy230fi7CBoMZUN4bPcMqRXksb449K 6r8kuPAm5yNYp+1HAzVUJMzdNzUHRiW8/hkqPal4utd29p11Fm82TaTn+QxBYioZ/k TDvuhv/igCZjMlx67qcqv5HIgW6qVLSBqRtGGI2KPjBPb1G4UaZUGiNow2kjPif8QM Rd3SlDZ6Y2APA== Date: Tue, 7 Jun 2022 17:20:39 +0100 From: Mark Brown To: Xiaohui Zhang Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] spi: fix use after free in of_spi_notify Message-ID: References: <20220607155233.27235-1-xiaohuizhang@ruc.edu.cn> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="TVcPyVtbuby/o9WR" Content-Disposition: inline In-Reply-To: <20220607155233.27235-1-xiaohuizhang@ruc.edu.cn> X-Cookie: Where's SANDY DUNCAN? Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --TVcPyVtbuby/o9WR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 07, 2022 at 11:52:33PM +0800, Xiaohui Zhang wrote: > We can't use "ctlr->dev" after it has been freed. > spi =3D of_register_spi_device(ctlr, rd->dn); > - put_device(&ctlr->dev); > =20 > if (IS_ERR(spi)) { > pr_err("%s: failed to create for '%pOF'\n", > __func__, rd->dn); > + put_device(&ctlr->dev); > of_node_clear_flag(rd->dn, OF_POPULATED); > return notifier_from_errno(PTR_ERR(spi)); > } > + put_device(&ctlr->dev); > break; Could you be more explicit about where the problematic use of ctlr->dev is please? --TVcPyVtbuby/o9WR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmKfetcACgkQJNaLcl1U h9DqjQf/Sqhd8EwOOC3Tz3LWmIt8e8a9/0Tz3BKJ+BnMEu0OvgpypqYFAKkwmKo5 eus+x+63OYod/Gv6nZplOOdo7hCwTvG2Cfw8RSpp+2NQiSl3repfVb/OXdFlizm6 xCS39kszeGsWNTE4lZ6c4ivseeJD1niCQ8WjYbB94ozvqVZbm5/YvQWzxG7PT2c+ SvkAaeNkh1OV3GbRCSLu8ANLTHePt4iBnq1L3bcQnxXC+V7N+NRWMb3L67wSzvNj lAoyl+jUKniAg8d0kcV+j5H3cS95usOnNGDAqeXQtjcGDX846lPsGVhJQ5g0RU4E kftauAlFT43fOlYnU3VOX9HvhXtRbQ== =Sbkt -----END PGP SIGNATURE----- --TVcPyVtbuby/o9WR--