From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 453B1C433EF for ; Tue, 7 Jun 2022 16:28:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345008AbiFGQ2X (ORCPT ); Tue, 7 Jun 2022 12:28:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235612AbiFGQ2T (ORCPT ); Tue, 7 Jun 2022 12:28:19 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80B9B75221; Tue, 7 Jun 2022 09:28:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654619298; x=1686155298; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ExbyLBBVlB99JJjQlhxs6g9MkUreWgPpOBU5Q2moeO4=; b=O9YzUUrgNny0g1n/fjKkK7nD8ghcJD67N3bjISH/S5QHPhJkUCMX98vA xThtctH/e5rbnsRCWnoo8cF/FRfHv40Iju/Jop7XzgfBOplV5taafuBlh UwD05gjOcWsLrj4Zp6Mcx25Y8yoje7yzykrdyBH4QAjL+iWnP6aGSzHuO RNimX/+NJ4cGpoMKlCFQ5V+U2chylJJ2Q2concdccOtSdmrdiUq8xbG2C 0sCHohRIGAUoz56vI/y/oHNJ8OeHuR7hNxPt2uITCWE9vhdieEe3vPibu UR411XX79ymUXMpxwfFIGBEaP9mXcxW6xLlN8NGxgUygEUFfvGj6ZM5j5 g==; X-IronPort-AV: E=McAfee;i="6400,9594,10371"; a="257171093" X-IronPort-AV: E=Sophos;i="5.91,284,1647327600"; d="scan'208";a="257171093" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2022 09:28:18 -0700 X-IronPort-AV: E=Sophos;i="5.91,284,1647327600"; d="scan'208";a="723396141" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2022 09:28:12 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nyc3s-000Vr1-Gp; Tue, 07 Jun 2022 19:28:08 +0300 Date: Tue, 7 Jun 2022 19:28:08 +0300 From: Andy Shevchenko To: Alexander Lobakin Cc: Marco Elver , Arnd Bergmann , Yury Norov , Richard Henderson , Matt Turner , Brian Cain , Geert Uytterhoeven , Yoshinori Sato , Rich Felker , "David S. Miller" , Kees Cook , "Peter Zijlstra (Intel)" , Borislav Petkov , Tony Luck , Greg Kroah-Hartman , linux-alpha@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] bitops: define gen_test_bit() the same way as the rest of functions Message-ID: References: <20220606114908.962562-1-alexandr.lobakin@intel.com> <20220606114908.962562-4-alexandr.lobakin@intel.com> <20220607155722.44040-1-alexandr.lobakin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220607155722.44040-1-alexandr.lobakin@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 07, 2022 at 05:57:22PM +0200, Alexander Lobakin wrote: > From: Marco Elver > Date: Tue, 7 Jun 2022 15:43:49 +0200 > > On Mon, Jun 06, 2022 at 01:49PM +0200, Alexander Lobakin wrote: ... > > I would also propose adding a comment close to the deref that test_bit() > > is atomic and the deref needs to remain volatile, so future people will > > not try to do the same optimization. > > I think that's also the reason why it's not underscored, right? Non-__ prefixed bitops are atomic, __ non-atomic. -- With Best Regards, Andy Shevchenko