From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Xiaohui Zhang <xiaohuizhang@ruc.edu.cn>
Cc: Ian Abbott <abbotti@mev.co.uk>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
Johan Hovold <johan@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 1/1] comedi: ni_usb6501: fix transfer-buffer overflows
Date: Tue, 7 Jun 2022 17:39:45 +0200 [thread overview]
Message-ID: <Yp9xQeXfsJ+sP4WB@kroah.com> (raw)
In-Reply-To: <20220607134720.6343-1-xiaohuizhang@ruc.edu.cn>
On Tue, Jun 07, 2022 at 09:47:20PM +0800, Xiaohui Zhang wrote:
> Similar to the handling of vmk80xx_alloc_usb_buffers in commit
> a23461c47482("comedi: vmk80xx: fix transfer-buffer overflows"),
> we thought a patch might be needed here as well.
>
> The driver uses endpoint-sized USB transfer buffers but up until
> recently had no sanity checks on the sizes.
>
> ---
>
> Fix the typo in the last bit of the old patch which use the wrong
> endpoint to determine the size for usb_tx_buf.
>
> Signed-off-by: Xiaohui Zhang <xiaohuizhang@ruc.edu.cn>
> ---
Please read the documentation links I sent you that say how to properly
document this.
Please do so and then you can submit a v3.
thanks,
greg k-h
prev parent reply other threads:[~2022-06-07 15:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 13:47 [PATCH V2 1/1] comedi: ni_usb6501: fix transfer-buffer overflows Xiaohui Zhang
2022-06-07 15:39 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yp9xQeXfsJ+sP4WB@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abbotti@mev.co.uk \
--cc=hsweeten@visionengravers.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiaohuizhang@ruc.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox