From: Sean Christopherson <seanjc@google.com>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
"open list:KERNEL VIRTUAL MACHINE FOR X86 (KVM/x86)"
<kvm@vger.kernel.org>,
"open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] KVM: Only display message about bios support disabled once
Date: Fri, 27 May 2022 16:08:11 +0000 [thread overview]
Message-ID: <YpD3a3wMbr9xIsub@google.com> (raw)
In-Reply-To: <20220526213038.2027-1-mario.limonciello@amd.com>
On Thu, May 26, 2022, Mario Limonciello wrote:
> On an OEM laptop I see the following message 10 times in my dmesg:
> "kvm: support for 'kvm_amd' disabled by bios"
>
> This might be useful the first time, but there really isn't a point
> to showing the error 9 more times. The BIOS still has it disabled.
> Change the message to only display one time.
NAK, this has been discussed multiple times in the past[1][2], there are edge cases
where logging multiple messages is desirable. Even using a ratelimited printk is
essentially a workaround for a systemd bug[3], which I'm guessing is the cuplrit here.
[1] https://lore.kernel.org/all/20190826182320.9089-1-tony.luck@intel.com
[2] https://lore.kernel.org/all/20200214143035.607115-1-e.velu@criteo.com
[3] https://github.com/systemd/systemd/issues/14906
next prev parent reply other threads:[~2022-05-27 16:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 21:30 [PATCH] KVM: Only display message about bios support disabled once Mario Limonciello
2022-05-27 16:08 ` Sean Christopherson [this message]
2022-06-01 1:57 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YpD3a3wMbr9xIsub@google.com \
--to=seanjc@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox