From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BD4BC433EF for ; Fri, 27 May 2022 16:08:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349558AbiE0QIV (ORCPT ); Fri, 27 May 2022 12:08:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343566AbiE0QIR (ORCPT ); Fri, 27 May 2022 12:08:17 -0400 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B90D1498CD for ; Fri, 27 May 2022 09:08:16 -0700 (PDT) Received: by mail-pj1-x102b.google.com with SMTP id x2-20020a17090a1f8200b001e07a64c461so7484072pja.4 for ; Fri, 27 May 2022 09:08:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=84jyFcXhy+7LS/4BL2qQwkaV7/d2/eHd1cRcTDWz3EI=; b=QmoCCOzPCZXeGFX5CxM6xUDiY5xxA+rTy9f87DS8FUZKehOK7jj4/99vNCnYbkcfJr dF/V4fITPoPzxDK+3WxS+PeU7HHbChP0uUK6b7iniYkYhpqBpXjxZy2m05AeC5DRW8wz 7RJubuU1csiLGslSaCj9hkDJ+Uj3by1iGoG8ikhy/9lyaS57pkfvTmTp+MvfhgFqz93W gjF0Qb80xn0/bquGTnwg1C3dSUfhZV9crL6gcbTJdLfRHoeG0ZPDtWsL1QmpxkrnPL5/ 4aJH5JoMTyRRu5UCLiVQnARlAZ9oMhPG9SFEIr1aJs+zr5lnDe7Rn0pk+0Y01hxGtuRV RPxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=84jyFcXhy+7LS/4BL2qQwkaV7/d2/eHd1cRcTDWz3EI=; b=CVIVODXDnfNUl3T7I5+HHP6riCE6Qmj+m4H1XjE/qi4nigy8qh2AbaIaBu9g7keIzL q7rVuwxEXcR2cP4noK8I0yHE3EsLLyZacWMw7Swfjk5F69eKjFqPmSDwLnK3DyfjFt1t Q2MReUbbzJ67LL4qOQsrwc6sSmyFQV0tDsH50f0hUnhCgD6HLVVSZFX+HhuBfRH6TLUq FT/hWsRfYNZKlo3rs8z2u7m1wHQFO7psLdeI8dKlawCsamcA0ADzOk5eYujS70ArWQIR 5bS+zLgnbmMh9YFlvWBJVDGCB4Y68rmy6Hg2bsuSCoHNf8d9PCa1d8N/ZNTzbMJab3ra TQZw== X-Gm-Message-State: AOAM531DGrooCY41dCHFSfLyXIEiVMP9kMuB3HhJmpjHueVPbBTijS/X EUrvZ80fCYvXsOS4ZrqPyDYePw== X-Google-Smtp-Source: ABdhPJxCYf8ECYcq48k6t4Rw29fmZa2p0+9eyg0bk1zPMkSRqOghqvhNkFmeNCYmK0xgHg8G4SGobg== X-Received: by 2002:a17:902:f548:b0:163:90d0:ada8 with SMTP id h8-20020a170902f54800b0016390d0ada8mr5215300plf.22.1653667695905; Fri, 27 May 2022 09:08:15 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id k12-20020a170902d58c00b0016366fbc155sm3798927plh.255.2022.05.27.09.08.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 May 2022 09:08:14 -0700 (PDT) Date: Fri, 27 May 2022 16:08:11 +0000 From: Sean Christopherson To: Mario Limonciello Cc: Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , "open list:KERNEL VIRTUAL MACHINE FOR X86 (KVM/x86)" , "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" Subject: Re: [PATCH] KVM: Only display message about bios support disabled once Message-ID: References: <20220526213038.2027-1-mario.limonciello@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220526213038.2027-1-mario.limonciello@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 26, 2022, Mario Limonciello wrote: > On an OEM laptop I see the following message 10 times in my dmesg: > "kvm: support for 'kvm_amd' disabled by bios" > > This might be useful the first time, but there really isn't a point > to showing the error 9 more times. The BIOS still has it disabled. > Change the message to only display one time. NAK, this has been discussed multiple times in the past[1][2], there are edge cases where logging multiple messages is desirable. Even using a ratelimited printk is essentially a workaround for a systemd bug[3], which I'm guessing is the cuplrit here. [1] https://lore.kernel.org/all/20190826182320.9089-1-tony.luck@intel.com [2] https://lore.kernel.org/all/20200214143035.607115-1-e.velu@criteo.com [3] https://github.com/systemd/systemd/issues/14906