From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org,
Charles Mirabile <cmirabil@redhat.com>,
Daniel Bauman <dbauman@redhat.com>,
Mwesigwa Guma <mguma@redhat.com>,
Joel Savitz <jsavitz@redhat.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH -next] Input: joystick: Raspberry Pi Sense HAT depends on HAS_IOMEM
Date: Tue, 31 May 2022 14:10:41 -0700 [thread overview]
Message-ID: <YpaEUZYtlVf2aCuA@google.com> (raw)
In-Reply-To: <20220531022942.16340-1-rdunlap@infradead.org>
On Mon, May 30, 2022 at 07:29:42PM -0700, Randy Dunlap wrote:
> Since JOYSTICK_SENSEHAT selects MFD_SIMPLE_MFD_I2C and the latter
> depends on HAS_IOMEM, and since 'select' does not follow any
> dependency chains, JOYSTICK_SENSEHAT should also depend on HAS_IOMEM
> to prevent a kconfig warning and a build error:
>
> WARNING: unmet direct dependencies detected for MFD_SIMPLE_MFD_I2C
> Depends on [n]: HAS_IOMEM [=n] && I2C [=y]
> Selected by [y]:
> - JOYSTICK_SENSEHAT [=y] && INPUT_JOYSTICK [=y] && INPUT [=y] && I2C [=y]
>
> s390-linux-ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_probe':
> simple-mfd-i2c.c:(.text+0xc8): undefined reference to `devm_mfd_add_devices'
>
> Fixes: 41657514c796 ("Input: add Raspberry Pi Sense HAT joystick driver")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Charles Mirabile <cmirabil@redhat.com>
> Cc: Daniel Bauman <dbauman@redhat.com>
> Cc: Mwesigwa Guma <mguma@redhat.com>
> Cc: Joel Savitz <jsavitz@redhat.com>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: linux-input@vger.kernel.org
Applied, thank you.
--
Dmitry
prev parent reply other threads:[~2022-05-31 21:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 2:29 [PATCH -next] Input: joystick: Raspberry Pi Sense HAT depends on HAS_IOMEM Randy Dunlap
2022-05-31 21:10 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YpaEUZYtlVf2aCuA@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=cmirabil@redhat.com \
--cc=dbauman@redhat.com \
--cc=jsavitz@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mguma@redhat.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox