* [PATCH] staging: r8188eu: Drop redundant memset
@ 2022-06-01 9:35 Haowen Bai
2022-06-01 10:01 ` Larry Finger
0 siblings, 1 reply; 5+ messages in thread
From: Haowen Bai @ 2022-06-01 9:35 UTC (permalink / raw)
To: Larry Finger, Phillip Potter, Greg Kroah-Hartman
Cc: Haowen Bai, linux-staging, linux-kernel
The region set by the call to memset is immediately overwritten by the
subsequent call to memcpy. So we drop redundant memset.
Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
drivers/staging/r8188eu/core/rtw_mlme.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r8188eu/core/rtw_mlme.c
index 5a815642c3f6..56c8bd5f4c60 100644
--- a/drivers/staging/r8188eu/core/rtw_mlme.c
+++ b/drivers/staging/r8188eu/core/rtw_mlme.c
@@ -676,7 +676,6 @@ void rtw_surveydone_event_callback(struct adapter *adapter, u8 *pbuf)
_clr_fwstate_(pmlmepriv, _FW_UNDER_SURVEY);
- memset(&pdev_network->Ssid, 0, sizeof(struct ndis_802_11_ssid));
memcpy(&pdev_network->Ssid, &pmlmepriv->assoc_ssid, sizeof(struct ndis_802_11_ssid));
rtw_update_registrypriv_dev_network(adapter);
@@ -1253,7 +1252,6 @@ void rtw_stadel_event_callback(struct adapter *adapter, u8 *pbuf)
memcpy(pdev_network, &tgt_network->network, get_wlan_bssid_ex_sz(&tgt_network->network));
- memset(&pdev_network->Ssid, 0, sizeof(struct ndis_802_11_ssid));
memcpy(&pdev_network->Ssid, &pmlmepriv->assoc_ssid, sizeof(struct ndis_802_11_ssid));
rtw_update_registrypriv_dev_network(adapter);
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: r8188eu: Drop redundant memset
2022-06-01 9:35 [PATCH] staging: r8188eu: Drop redundant memset Haowen Bai
@ 2022-06-01 10:01 ` Larry Finger
2022-06-01 10:05 ` [PATCH V2] staging: r8188eu: Drop redundant memset overwritten by memcpy Haowen Bai
0 siblings, 1 reply; 5+ messages in thread
From: Larry Finger @ 2022-06-01 10:01 UTC (permalink / raw)
To: Haowen Bai, Phillip Potter, Greg Kroah-Hartman
Cc: linux-staging, linux-kernel
On 6/1/22 04:35, Haowen Bai wrote:
> The region set by the call to memset is immediately overwritten by the
> subsequent call to memcpy. So we drop redundant memset.
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
> drivers/staging/r8188eu/core/rtw_mlme.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r8188eu/core/rtw_mlme.c
> index 5a815642c3f6..56c8bd5f4c60 100644
> --- a/drivers/staging/r8188eu/core/rtw_mlme.c
> +++ b/drivers/staging/r8188eu/core/rtw_mlme.c
> @@ -676,7 +676,6 @@ void rtw_surveydone_event_callback(struct adapter *adapter, u8 *pbuf)
>
> _clr_fwstate_(pmlmepriv, _FW_UNDER_SURVEY);
>
> - memset(&pdev_network->Ssid, 0, sizeof(struct ndis_802_11_ssid));
> memcpy(&pdev_network->Ssid, &pmlmepriv->assoc_ssid, sizeof(struct ndis_802_11_ssid));
>
> rtw_update_registrypriv_dev_network(adapter);
> @@ -1253,7 +1252,6 @@ void rtw_stadel_event_callback(struct adapter *adapter, u8 *pbuf)
>
> memcpy(pdev_network, &tgt_network->network, get_wlan_bssid_ex_sz(&tgt_network->network));
>
> - memset(&pdev_network->Ssid, 0, sizeof(struct ndis_802_11_ssid));
> memcpy(&pdev_network->Ssid, &pmlmepriv->assoc_ssid, sizeof(struct ndis_802_11_ssid));
>
> rtw_update_registrypriv_dev_network(adapter);
You supplied two patches with the same subject that do different things. That is
confusing to everyone. Please redo with unique subjects.
Larry
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH V2] staging: r8188eu: Drop redundant memset overwritten by memcpy
2022-06-01 10:01 ` Larry Finger
@ 2022-06-01 10:05 ` Haowen Bai
2022-06-01 10:18 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Haowen Bai @ 2022-06-01 10:05 UTC (permalink / raw)
To: larry.finger; +Cc: baihaowen, gregkh, linux-kernel, linux-staging, phil
The region set by the call to memset is immediately overwritten by the
subsequent call to memcpy. So we drop redundant memset.
Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
V1->V2: change title for unique subjects.
drivers/staging/r8188eu/core/rtw_mlme.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r8188eu/core/rtw_mlme.c
index 5a815642c3f6..56c8bd5f4c60 100644
--- a/drivers/staging/r8188eu/core/rtw_mlme.c
+++ b/drivers/staging/r8188eu/core/rtw_mlme.c
@@ -676,7 +676,6 @@ void rtw_surveydone_event_callback(struct adapter *adapter, u8 *pbuf)
_clr_fwstate_(pmlmepriv, _FW_UNDER_SURVEY);
- memset(&pdev_network->Ssid, 0, sizeof(struct ndis_802_11_ssid));
memcpy(&pdev_network->Ssid, &pmlmepriv->assoc_ssid, sizeof(struct ndis_802_11_ssid));
rtw_update_registrypriv_dev_network(adapter);
@@ -1253,7 +1252,6 @@ void rtw_stadel_event_callback(struct adapter *adapter, u8 *pbuf)
memcpy(pdev_network, &tgt_network->network, get_wlan_bssid_ex_sz(&tgt_network->network));
- memset(&pdev_network->Ssid, 0, sizeof(struct ndis_802_11_ssid));
memcpy(&pdev_network->Ssid, &pmlmepriv->assoc_ssid, sizeof(struct ndis_802_11_ssid));
rtw_update_registrypriv_dev_network(adapter);
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH V2] staging: r8188eu: Drop redundant memset overwritten by memcpy
2022-06-01 10:05 ` [PATCH V2] staging: r8188eu: Drop redundant memset overwritten by memcpy Haowen Bai
@ 2022-06-01 10:18 ` Greg KH
2022-06-01 11:49 ` [PATCH V3] " Haowen Bai
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2022-06-01 10:18 UTC (permalink / raw)
To: Haowen Bai; +Cc: larry.finger, linux-kernel, linux-staging, phil
On Wed, Jun 01, 2022 at 06:05:26PM +0800, Haowen Bai wrote:
> The region set by the call to memset is immediately overwritten by the
> subsequent call to memcpy. So we drop redundant memset.
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
> V1->V2: change title for unique subjects.
That's not really unique, why is this just not 1 patch with both changes
in it as you are doing the same thing to the same driver source, just in
different locations in the files.
Please merge together.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH V3] staging: r8188eu: Drop redundant memset overwritten by memcpy
2022-06-01 10:18 ` Greg KH
@ 2022-06-01 11:49 ` Haowen Bai
0 siblings, 0 replies; 5+ messages in thread
From: Haowen Bai @ 2022-06-01 11:49 UTC (permalink / raw)
To: gregkh; +Cc: baihaowen, larry.finger, linux-kernel, linux-staging, phil
The region set by the call to memset is immediately overwritten by the
subsequent call to memcpy. So we drop redundant memset.
Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
V1->V2: change title for unique subjects.
V2->V3: merge 1 patch with both changes.
drivers/staging/r8188eu/core/rtw_ioctl_set.c | 1 -
drivers/staging/r8188eu/core/rtw_mlme.c | 2 --
2 files changed, 3 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_ioctl_set.c b/drivers/staging/r8188eu/core/rtw_ioctl_set.c
index 7ba75f73e47e..17f6bcbeebf4 100644
--- a/drivers/staging/r8188eu/core/rtw_ioctl_set.c
+++ b/drivers/staging/r8188eu/core/rtw_ioctl_set.c
@@ -71,7 +71,6 @@ u8 rtw_do_join(struct adapter *padapter)
pibss = padapter->registrypriv.dev_network.MacAddress;
- memset(&pdev_network->Ssid, 0, sizeof(struct ndis_802_11_ssid));
memcpy(&pdev_network->Ssid, &pmlmepriv->assoc_ssid, sizeof(struct ndis_802_11_ssid));
rtw_update_registrypriv_dev_network(padapter);
diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r8188eu/core/rtw_mlme.c
index 5a815642c3f6..56c8bd5f4c60 100644
--- a/drivers/staging/r8188eu/core/rtw_mlme.c
+++ b/drivers/staging/r8188eu/core/rtw_mlme.c
@@ -676,7 +676,6 @@ void rtw_surveydone_event_callback(struct adapter *adapter, u8 *pbuf)
_clr_fwstate_(pmlmepriv, _FW_UNDER_SURVEY);
- memset(&pdev_network->Ssid, 0, sizeof(struct ndis_802_11_ssid));
memcpy(&pdev_network->Ssid, &pmlmepriv->assoc_ssid, sizeof(struct ndis_802_11_ssid));
rtw_update_registrypriv_dev_network(adapter);
@@ -1253,7 +1252,6 @@ void rtw_stadel_event_callback(struct adapter *adapter, u8 *pbuf)
memcpy(pdev_network, &tgt_network->network, get_wlan_bssid_ex_sz(&tgt_network->network));
- memset(&pdev_network->Ssid, 0, sizeof(struct ndis_802_11_ssid));
memcpy(&pdev_network->Ssid, &pmlmepriv->assoc_ssid, sizeof(struct ndis_802_11_ssid));
rtw_update_registrypriv_dev_network(adapter);
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-06-01 11:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-01 9:35 [PATCH] staging: r8188eu: Drop redundant memset Haowen Bai
2022-06-01 10:01 ` Larry Finger
2022-06-01 10:05 ` [PATCH V2] staging: r8188eu: Drop redundant memset overwritten by memcpy Haowen Bai
2022-06-01 10:18 ` Greg KH
2022-06-01 11:49 ` [PATCH V3] " Haowen Bai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox