From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Marius Hoch <mail@mariushoch.de>, Hans de Goede <hdegoede@redhat.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: soc_button_array - also add Lenovo Yoga Tablet2 1051F to dmi_use_low_level_irq
Date: Fri, 3 Jun 2022 15:33:22 -0700 [thread overview]
Message-ID: <YpqMMmIH6Rr0RbeP@google.com> (raw)
In-Reply-To: <20220603120246.3065-1-mail@mariushoch.de>
On Fri, Jun 03, 2022 at 02:02:46PM +0200, Marius Hoch wrote:
> Commit 223f61b8c5ad ("Input: soc_button_array - add Lenovo Yoga Tablet2
> 1051L to the dmi_use_low_level_irq list") added the 1051L to this list
> already, but the same problem applies to the 1051F. As there are no
> further 1051 variants (just the F/L), we can just DMI match 1051.
>
> Tested on a Lenovo Yoga Tablet2 1051F: Without this patch the
> home-button stops working after a wakeup from suspend.
>
> Signed-off-by: Marius Hoch <mail@mariushoch.de>
Adding Hans for his input...
> ---
> drivers/input/misc/soc_button_array.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/misc/soc_button_array.c b/drivers/input/misc/soc_button_array.c
> index cbb1599a520e..480476121c01 100644
> --- a/drivers/input/misc/soc_button_array.c
> +++ b/drivers/input/misc/soc_button_array.c
> @@ -85,13 +85,13 @@ static const struct dmi_system_id dmi_use_low_level_irq[] = {
> },
> {
> /*
> - * Lenovo Yoga Tab2 1051L, something messes with the home-button
> + * Lenovo Yoga Tab2 1051F/1051L, something messes with the home-button
> * IRQ settings, leading to a non working home-button.
> */
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> DMI_MATCH(DMI_PRODUCT_NAME, "60073"),
> - DMI_MATCH(DMI_PRODUCT_VERSION, "1051L"),
> + DMI_MATCH(DMI_PRODUCT_VERSION, "1051"),
> },
> },
> {} /* Terminating entry */
> --
> 2.36.1
>
--
Dmitry
next prev parent reply other threads:[~2022-06-03 22:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 12:02 [PATCH] Input: soc_button_array - also add Lenovo Yoga Tablet2 1051F to dmi_use_low_level_irq Marius Hoch
2022-06-03 22:33 ` Dmitry Torokhov [this message]
2022-06-04 14:01 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YpqMMmIH6Rr0RbeP@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@mariushoch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox