Re: [PATCH 2/3] platform/chrome: cros_ec_proto: Rename cros_ec_command function

Lee Jones
2022-06-08T08:18:01Z

On Mon, 06 Jun 2022, Prashant Malani wrote:

> cros_ec_command() is the name of a function as well as a struct, as such
> it can confuse indexing tools (like ctags). Avoid this by renaming it to
> cros_ec_cmd(). Update all the callsites to use the new name.
>
> This patch is a find-and-replace, so should not introduce any functional
> changes.
>
> Suggested-by: Stephen Boyd <swboyd@chromium.org>
> Signed-off-by: Prashant Malani <pmalani@chromium.org>
> ---
> drivers/mfd/cros_ec_dev.c | 4 +--

Acked-by: Lee Jones <lee.jones@linaro.org>

> drivers/platform/chrome/cros_ec_proto.c | 22 ++++++------
> drivers/platform/chrome/cros_ec_typec.c | 39 ++++++++++-----------
> drivers/platform/chrome/cros_usbpd_notify.c | 4 +--
> drivers/regulator/cros-ec-regulator.c | 24 ++++++-------
> include/linux/platform_data/cros_ec_proto.h | 2 +-
> 6 files changed, 47 insertions(+), 48 deletions(-)

--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog