From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A19CC43334 for ; Thu, 9 Jun 2022 18:10:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238013AbiFISK3 (ORCPT ); Thu, 9 Jun 2022 14:10:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344647AbiFISK2 (ORCPT ); Thu, 9 Jun 2022 14:10:28 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 074953AD8B1 for ; Thu, 9 Jun 2022 11:10:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 501F461D0D for ; Thu, 9 Jun 2022 18:10:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B0F9C34114; Thu, 9 Jun 2022 18:10:24 +0000 (UTC) Date: Thu, 9 Jun 2022 19:10:20 +0100 From: Catalin Marinas To: Patrick Wang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yee.lee@mediatek.com Subject: Re: [PATCH v3 2/3] mm: kmemleak: add rbtree and store physical address for objects allocated with PA Message-ID: References: <20220609124950.1694394-1-patrick.wang.shcn@gmail.com> <20220609124950.1694394-3-patrick.wang.shcn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220609124950.1694394-3-patrick.wang.shcn@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 09, 2022 at 08:49:49PM +0800, Patrick Wang wrote: > Add object_phys_tree_root to store the objects allocated with > physical address. Distinguish it from object_tree_root by > OBJECT_PHYS flag or function argument. The physical address > is stored directly in those objects. And remove the unused > kmemleak_not_leak_phys() function. > > Suggested-by: Catalin Marinas > Signed-off-by: Patrick Wang > --- > Documentation/dev-tools/kmemleak.rst | 1 - > include/linux/kmemleak.h | 4 - > mm/kmemleak.c | 145 +++++++++++++++++---------- > 3 files changed, 91 insertions(+), 59 deletions(-) > > diff --git a/Documentation/dev-tools/kmemleak.rst b/Documentation/dev-tools/kmemleak.rst > index 1c935f41cd3a..5483fd39ef29 100644 > --- a/Documentation/dev-tools/kmemleak.rst > +++ b/Documentation/dev-tools/kmemleak.rst > @@ -174,7 +174,6 @@ mapping: > > - ``kmemleak_alloc_phys`` > - ``kmemleak_free_part_phys`` > -- ``kmemleak_not_leak_phys`` > - ``kmemleak_ignore_phys`` Same comment - only if you respin, move the kmemleak_not_leak_phys() removal to a separate patch. Otherwise: Reviewed-by: Catalin Marinas