From: Peter Zijlstra <peterz@infradead.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Valentin Schneider <vschneid@redhat.com>,
K Prateek Nayak <kprateek.nayak@amd.com>,
aubrey.li@linux.intel.com, efault@gmx.de, gautham.shenoy@amd.com,
linux-kernel@vger.kernel.org, mgorman@techsingularity.net,
mingo@kernel.org, song.bao.hua@hisilicon.com,
srikar@linux.vnet.ibm.com, valentin.schneider@arm.com
Subject: Re: [PATCH v7] sched/fair: Consider cpu affinity when allowing NUMA imbalance in find_idlest_group
Date: Fri, 10 Jun 2022 17:01:27 +0200 [thread overview]
Message-ID: <YqNcx34HzVEnJmCf@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <CAKfTPtBDqgpjR2tkgQ6hwYnZ2b1azMX0EKQL1cbuUVbK48MnHA@mail.gmail.com>
On Fri, Jun 10, 2022 at 04:42:05PM +0200, Vincent Guittot wrote:
> The test was there to not do the computation with cpumask_and() if the
> task's affinity has not been modified so maybe it would be enough to
> test (p->nr_cpus_allowed != NR_CPUS) to check if the task's affinity
> has been modified and we have we do the cpumask_and() and
> cpumask_weight()
Yeah, I suppose that's the best we can do. I was thinking that perhaps
some cgroup/cpuset thing is common these days, in which case pretty much
all tasks will have their affinity set through the cpuset muck, but
alas, nothing really do be done about that.
next prev parent reply other threads:[~2022-06-10 15:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 11:12 [PATCH v7] sched/fair: Consider cpu affinity when allowing NUMA imbalance in find_idlest_group K Prateek Nayak
2022-05-12 6:11 ` K Prateek Nayak
2022-06-09 11:54 ` Peter Zijlstra
2022-06-10 10:55 ` Valentin Schneider
2022-06-10 14:15 ` Peter Zijlstra
2022-06-10 14:42 ` Vincent Guittot
2022-06-10 15:01 ` Peter Zijlstra [this message]
2022-06-10 16:25 ` Valentin Schneider
2022-06-13 12:05 ` K Prateek Nayak
2022-06-13 8:43 ` [tip: sched/core] sched/fair: Consider CPU affinity when allowing NUMA imbalance in find_idlest_group() tip-bot2 for K Prateek Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqNcx34HzVEnJmCf@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=aubrey.li@linux.intel.com \
--cc=efault@gmx.de \
--cc=gautham.shenoy@amd.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@techsingularity.net \
--cc=mingo@kernel.org \
--cc=song.bao.hua@hisilicon.com \
--cc=srikar@linux.vnet.ibm.com \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox