Re: [PATCH v2 000/144] KVM: selftests: Overhaul APIs, purge VCPU_ID

Sean Christopherson
2022-06-09T19:48:55Z

On Thu, Jun 09, 2022, Andrew Jones wrote:
> On Wed, Jun 08, 2022 at 11:20:06PM +0000, Sean Christopherson wrote:
> > On Wed, Jun 08, 2022, Marc Zyngier wrote:
> > > On 2022-06-07 16:27, Paolo Bonzini wrote:
> > > > Marc, Christian, Anup, can you please give this a go?
> > >
> > > Can you please, pretty please, once and for all, kill that alias you
> > > seem to have for me and email me on an address I actually can read?
> > >
> > > I can't remember how many times you emailed me on my ex @arm.com address
> > > over the past 2+years...
> > >
> > > The same thing probably applies to Sean, btw.
> >
> > Ha! I was wondering how my old @intel address snuck in...
> >
> > On the aarch64 side, with the following tweaks, courtesy of Raghu, all tests
> > pass. I'll work these into the next version, and hopefully also learn how to
> > run on aarch64 myself...
> >
> > Note, the i => 0 "fix" in test_v3_typer_accesses() is a direct revert of patch 3,
> > "KVM: selftests: Fix typo in vgic_init test". I'll just drop that patch unless
> > someone figures out why doing the right thing causes the test to fail.
>
> CCing Eric for that one.

> > @@ -424,7 +424,7 @@ static void test_v3_typer_accesses(void)
> > KVM_DEV_ARM_VGIC_CTRL_INIT, NULL);
> >
> > for (i = 0; i < NR_VCPUS ; i++) {
> > - ret = v3_redist_reg_get(v.gic_fd, i, GICR_TYPER, &val);
> > + ret = v3_redist_reg_get(v.gic_fd, 0, GICR_TYPER, &val);
> > TEST_ASSERT(!ret && !val, "read GICR_TYPER before rdist region setting");

Figured it out, "val" should be "i * 0x100", not "0". The asserts in this test
are awful and don't print the actual "val". test_assert() shares part of the blame
for printing a stale errno, but holy moly this test makes it painful to debug
trivial issues.