From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Ferry Toth <ftoth@exalondelft.nl>
Subject: Re: [PATCH v1 1/1] x86/PCI: Disable e820 usage for the resource allocation
Date: Tue, 14 Jun 2022 16:26:34 +0300 [thread overview]
Message-ID: <YqiMil2uTT1yDZ8d@smile.fi.intel.com> (raw)
In-Reply-To: <YqiEAN68MP0l4Mw6@smile.fi.intel.com>
On Tue, Jun 14, 2022 at 03:50:09PM +0300, Andy Shevchenko wrote:
> On Tue, Jun 14, 2022 at 03:30:08PM +0300, Andy Shevchenko wrote:
> > On Mon, Jun 13, 2022 at 10:31:39PM +0200, Hans de Goede wrote:
> > > On 6/13/22 22:16, Andy Shevchenko wrote:
> > > > The resource management improve for PCI on x86 broke booting of Intel MID
> > > > platforms. It seems that the current code removes all available resources
> > > > from the list and none of the PCI device may be initialized. Restore the
> > > > old behaviour by force disabling the e820 usage for the resource allocation.
> > > >
> > > > Fixes: 4c5e242d3e93 ("x86/PCI: Clip only host bridge windows for E820 regions")
> > > > Depends-on: fa6dae5d8208 ("x86/PCI: Add kernel cmdline options to use/ignore E820 reserved regions")
> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > >
> > > Andy, thank you for the patch. Commit 4c5e242d3e93 has also been causing
> > > issues for other platforms, so I've submitted a revert of it here:
> > >
> > > https://lore.kernel.org/linux-pci/20220612144325.85366-1-hdegoede@redhat.com/T/#u
> > >
> > > can you please give the revert a try, and confirm that that fixes
> > > the Intel MID platform issue too ?
> >
> > Nope, it doesn't fix. The problem is in flags checking as far as I can see.
> > My patch is needed either we have yours or not.
>
> Hold on, it seems I have tried to build something that is not what I develop.
> Lemme retest.
Yes, I have tested something weird. Now it works, but I will triple check and
give my tag to your patch later on.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-06-14 13:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-13 20:16 [PATCH v1 1/1] x86/PCI: Disable e820 usage for the resource allocation Andy Shevchenko
2022-06-13 20:31 ` Hans de Goede
2022-06-14 12:30 ` Andy Shevchenko
2022-06-14 12:50 ` Andy Shevchenko
2022-06-14 13:26 ` Andy Shevchenko [this message]
2022-06-13 22:35 ` Bjorn Helgaas
2022-06-14 11:55 ` Andy Shevchenko
2022-06-14 15:18 ` Bjorn Helgaas
2022-06-14 15:45 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqiMil2uTT1yDZ8d@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=ftoth@exalondelft.nl \
--cc=gustavoars@kernel.org \
--cc=hdegoede@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox