From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED7E4C433EF for ; Tue, 14 Jun 2022 13:26:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245542AbiFNN0n (ORCPT ); Tue, 14 Jun 2022 09:26:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232896AbiFNN0m (ORCPT ); Tue, 14 Jun 2022 09:26:42 -0400 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEFE83D1D0; Tue, 14 Jun 2022 06:26:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655213201; x=1686749201; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=JF8LZq8ZciI01zA/+wKZIM97ei6FRLP9TQo1UIhxw9U=; b=f8X3KVjA3/7H9hAw/LFI6De6YLBzJZprX5xnnWPpKwFAXRMddHmhWQK8 +KikZA88cFR+RWz4tVsYm2oZKITez3QWDM6WVBnOady3BMlPn20NgGZvZ qnRty7zFQNykqRpMLY4UYnLU3p16XvJw1AtcYfYQQOFGRY5ZADy1B68BX WpqQ4KtfDa7DWwImGRhmuxX+tTAiaRPzr/8N++IEBF8BjPUfzN83gVzOb 71NJp6f7HpAR4JF/Yq7PJ8PBxZYp/AI5/ZFnWwvSnIRQXyI9M8V+vGCcz q8eiDgMhdq5/oNo8VJTbdWY+2bO8Mlt0NU6ROritdtJf/ls2p2NsBQUov w==; X-IronPort-AV: E=McAfee;i="6400,9594,10377"; a="342579798" X-IronPort-AV: E=Sophos;i="5.91,300,1647327600"; d="scan'208";a="342579798" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jun 2022 06:26:41 -0700 X-IronPort-AV: E=Sophos;i="5.91,300,1647327600"; d="scan'208";a="588468908" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jun 2022 06:26:38 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1o16Z0-000cPE-UM; Tue, 14 Jun 2022 16:26:34 +0300 Date: Tue, 14 Jun 2022 16:26:34 +0300 From: Andy Shevchenko To: Hans de Goede Cc: "Gustavo A. R. Silva" , Bjorn Helgaas , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Ferry Toth Subject: Re: [PATCH v1 1/1] x86/PCI: Disable e820 usage for the resource allocation Message-ID: References: <20220613201641.67640-1-andriy.shevchenko@linux.intel.com> <45d458f5-4f4e-9ebd-cb51-1a7b784248ec@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 14, 2022 at 03:50:09PM +0300, Andy Shevchenko wrote: > On Tue, Jun 14, 2022 at 03:30:08PM +0300, Andy Shevchenko wrote: > > On Mon, Jun 13, 2022 at 10:31:39PM +0200, Hans de Goede wrote: > > > On 6/13/22 22:16, Andy Shevchenko wrote: > > > > The resource management improve for PCI on x86 broke booting of Intel MID > > > > platforms. It seems that the current code removes all available resources > > > > from the list and none of the PCI device may be initialized. Restore the > > > > old behaviour by force disabling the e820 usage for the resource allocation. > > > > > > > > Fixes: 4c5e242d3e93 ("x86/PCI: Clip only host bridge windows for E820 regions") > > > > Depends-on: fa6dae5d8208 ("x86/PCI: Add kernel cmdline options to use/ignore E820 reserved regions") > > > > Signed-off-by: Andy Shevchenko > > > > > > Andy, thank you for the patch. Commit 4c5e242d3e93 has also been causing > > > issues for other platforms, so I've submitted a revert of it here: > > > > > > https://lore.kernel.org/linux-pci/20220612144325.85366-1-hdegoede@redhat.com/T/#u > > > > > > can you please give the revert a try, and confirm that that fixes > > > the Intel MID platform issue too ? > > > > Nope, it doesn't fix. The problem is in flags checking as far as I can see. > > My patch is needed either we have yours or not. > > Hold on, it seems I have tried to build something that is not what I develop. > Lemme retest. Yes, I have tested something weird. Now it works, but I will triple check and give my tag to your patch later on. -- With Best Regards, Andy Shevchenko